Replace exec_tools with tools in bazel genrule. (#77510)

denglesberg-splunk · web-flow · commit 3b54337be541 · 2024-01-19T09:12:54.000+01:00
As of the Bazel 6.x series, there is no difference between the `exec_tools` and `tools`. Bazel 7 removes the `exec_tools` attribute entirely. This commit updates to use the cannonical attribute name to allow building `clang-tidy``with bazel 7.0.0, though it does not change the default bazel version which remains at 6.1.2. See also bazelbuild/bazel#19132 for more information.
diff --git a/utils/bazel/llvm-project-overlay/clang-tools-extra/clang-tidy/BUILD.bazel b/utils/bazel/llvm-project-overlay/clang-tools-extra/clang-tidy/BUILD.bazel
@@ -57,7 +57,7 @@ genrule(
     srcs = ["misc/ConfusableTable/confusables.txt"],
     outs = ["Confusables.inc"],
     cmd = "$(location :confusable_table_builder) $(SRCS) $(OUTS)",
-    exec_tools = [":confusable_table_builder"],
+    tools = [":confusable_table_builder"],
     visibility = ["//visibility:private"],
 )
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ genrule(`
`57`	`57`	`srcs = ["misc/ConfusableTable/confusables.txt"],`
`58`	`58`	`outs = ["Confusables.inc"],`
`59`	`59`	`cmd = "$(location :confusable_table_builder) $(SRCS) $(OUTS)",`
`60`		`- exec_tools = [":confusable_table_builder"],`
	`60`	`+ tools = [":confusable_table_builder"],`
`61`	`61`	`visibility = ["//visibility:private"],`
`62`	`62`	`)`
`63`	`63`