Skip to content

Commit 3b7cf6e

Browse files
committed
Fix double-quotes in diagnostic when attempting to access a ext_vector of bools
1 parent 9edbe56 commit 3b7cf6e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

clang/lib/Sema/SemaExprMember.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1655,8 +1655,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
16551655
// We disallow element access for ext_vector_type bool. There is no way to
16561656
// materialize a reference to a vector element as a pointer (each element is
16571657
// one bit in the vector).
1658+
assert(MemberName.isIdentifier() &&
1659+
"Ext vector component name not an identifier!");
16581660
S.Diag(R.getNameLoc(), diag::err_ext_vector_component_name_illegal)
1659-
<< MemberName
1661+
<< MemberName.getAsIdentifierInfo()->getName()
16601662
<< (BaseExpr.get() ? BaseExpr.get()->getSourceRange() : SourceRange());
16611663
return ExprError();
16621664
}

clang/test/SemaCXX/vector-bool.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ void foo(const bool& X);
8585

8686
// Disallow element-wise access.
8787
bool* ElementRefs() {
88-
eight_bools.y = false; // expected-error@88 {{illegal vector component name ''y''}}
89-
&eight_bools.z; // expected-error@89 {{illegal vector component name ''z''}}
90-
foo(eight_bools.w); // expected-error@90 {{illegal vector component name ''w''}}
91-
foo(eight_bools.wyx); // expected-error@91 {{illegal vector component name ''wyx''}}
88+
eight_bools.y = false; // expected-error@88 {{illegal vector component name 'y'}}
89+
&eight_bools.z; // expected-error@89 {{illegal vector component name 'z'}}
90+
foo(eight_bools.w); // expected-error@90 {{illegal vector component name 'w'}}
91+
foo(eight_bools.wyx); // expected-error@91 {{illegal vector component name 'wyx'}}
9292
}
9393

9494
void Sizeof() {

0 commit comments

Comments
 (0)