Do not provide memory references for arrays. Dereference did not work anyway

vogelsgesang · vogelsgesang · commit 3b7e326d1fec · 2024-09-16T10:05:25.000Z
diff --git a/lldb/tools/lldb-dap/JSONUtils.cpp b/lldb/tools/lldb-dap/JSONUtils.cpp
@@ -1196,7 +1196,7 @@ std::string VariableDescription::GetResult(llvm::StringRef context) {
 }
 
 std::optional<lldb::addr_t> GetMemoryReference(lldb::SBValue v) {
-  if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType())
+  if (!v.GetType().IsPointerType())
     return std::nullopt;
 
   lldb::SBValue deref = v.Dereference();

Original file line number	Diff line number	Diff line change
`@@ -1196,7 +1196,7 @@ std::string VariableDescription::GetResult(llvm::StringRef context) {`
`1196`	`1196`	`}`
`1197`	`1197`
`1198`	`1198`	`std::optional<lldb::addr_t> GetMemoryReference(lldb::SBValue v) {`
`1199`		`- if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType())`
	`1199`	`+ if (!v.GetType().IsPointerType())`
`1200`	`1200`	`return std::nullopt;`
`1201`	`1201`
`1202`	`1202`	`lldb::SBValue deref = v.Dereference();`