Revert "[Serialization] Read the initializer for interesting static variables before consuming it (#92218)"

This reverts commit 3a4c1b9.

This breaks a bot on clang-s390x-linux

Author: ChuanqiXu9

clang/lib/Serialization/ASTReaderDecl.cpp

@@ -4186,35 +4186,12 @@ void ASTReader::PassInterestingDeclsToConsumer() {
     GetDecl(ID);
   EagerlyDeserializedDecls.clear();
 
-  auto ConsumingPotentialInterestingDecls = [this]() {
-    while (!PotentiallyInterestingDecls.empty()) {
-      Decl *D = PotentiallyInterestingDecls.front();
-      PotentiallyInterestingDecls.pop_front();
-      if (isConsumerInterestedIn(D))
-        PassInterestingDeclToConsumer(D);
-    }
-  };
-  std::deque<Decl *> MaybeInterestingDecls =
-      std::move(PotentiallyInterestingDecls);
-  assert(PotentiallyInterestingDecls.empty());
-  while (!MaybeInterestingDecls.empty()) {
-    Decl *D = MaybeInterestingDecls.front();
-    MaybeInterestingDecls.pop_front();
-    // Since we load the variable's initializers lazily, it'd be problematic
-    // if the initializers dependent on each other. So here we try to load the
-    // initializers of static variables to make sure they are passed to code
-    // generator by order. If we read anything interesting, we would consume
-    // that before emitting the current declaration.
-    if (auto *VD = dyn_cast<VarDecl>(D);
-        VD && VD->isFileVarDecl() && !VD->isExternallyVisible())
-      VD->getInit();
-    ConsumingPotentialInterestingDecls();
+  while (!PotentiallyInterestingDecls.empty()) {
+    Decl *D = PotentiallyInterestingDecls.front();
+    PotentiallyInterestingDecls.pop_front();
     if (isConsumerInterestedIn(D))
       PassInterestingDeclToConsumer(D);
   }
-
-  // If we add any new potential interesting decl in the last call, consume it.
-  ConsumingPotentialInterestingDecls();
 }
 
 void ASTReader::loadDeclUpdateRecords(PendingUpdateRecord &Record) {