Skip to content

Commit 3c2ba68

Browse files
authored
[lldb] Don't warn that libobjc was read from memory in corefile (#127138)
AppleObjCRuntimeV2 prints a warning when we read libobjc.A.dylib from memory, as a canary to detect that we are reading system binaries out of memory (which is slow, and we try hard to avoid). But with a corefile, reading out of "memory" is fine, and may be the only way we can find the correct binary. rdar://144322688
1 parent 0454dd8 commit 3c2ba68

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2666,6 +2666,9 @@ void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() {
26662666
if (!object_file->IsInMemory())
26672667
return;
26682668

2669+
if (!GetProcess()->IsLiveDebugSession())
2670+
return;
2671+
26692672
Target &target = GetProcess()->GetTarget();
26702673
Debugger &debugger = target.GetDebugger();
26712674

0 commit comments

Comments
 (0)