Skip to content

Commit 3c58e53

Browse files
committed
[AMDGPU] Use const reference in SIInstrInfo::buildExtractSubReg. NFC.
1 parent 7caff73 commit 3c58e53

File tree

2 files changed

+13
-20
lines changed

2 files changed

+13
-20
lines changed

llvm/lib/Target/AMDGPU/SIInstrInfo.cpp

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5416,13 +5416,10 @@ void SIInstrInfo::legalizeOpWithMove(MachineInstr &MI, unsigned OpIdx) const {
54165416
MO.ChangeToRegister(Reg, false);
54175417
}
54185418

5419-
unsigned SIInstrInfo::buildExtractSubReg(MachineBasicBlock::iterator MI,
5420-
MachineRegisterInfo &MRI,
5421-
MachineOperand &SuperReg,
5422-
const TargetRegisterClass *SuperRC,
5423-
unsigned SubIdx,
5424-
const TargetRegisterClass *SubRC)
5425-
const {
5419+
unsigned SIInstrInfo::buildExtractSubReg(
5420+
MachineBasicBlock::iterator MI, MachineRegisterInfo &MRI,
5421+
const MachineOperand &SuperReg, const TargetRegisterClass *SuperRC,
5422+
unsigned SubIdx, const TargetRegisterClass *SubRC) const {
54265423
MachineBasicBlock *MBB = MI->getParent();
54275424
DebugLoc DL = MI->getDebugLoc();
54285425
Register SubReg = MRI.createVirtualRegister(SubRC);
@@ -5449,12 +5446,9 @@ unsigned SIInstrInfo::buildExtractSubReg(MachineBasicBlock::iterator MI,
54495446
}
54505447

54515448
MachineOperand SIInstrInfo::buildExtractSubRegOrImm(
5452-
MachineBasicBlock::iterator MII,
5453-
MachineRegisterInfo &MRI,
5454-
MachineOperand &Op,
5455-
const TargetRegisterClass *SuperRC,
5456-
unsigned SubIdx,
5457-
const TargetRegisterClass *SubRC) const {
5449+
MachineBasicBlock::iterator MII, MachineRegisterInfo &MRI,
5450+
const MachineOperand &Op, const TargetRegisterClass *SuperRC,
5451+
unsigned SubIdx, const TargetRegisterClass *SubRC) const {
54585452
if (Op.isImm()) {
54595453
if (SubIdx == AMDGPU::sub0)
54605454
return MachineOperand::CreateImm(static_cast<int32_t>(Op.getImm()));

llvm/lib/Target/AMDGPU/SIInstrInfo.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,16 +102,15 @@ class SIInstrInfo final : public AMDGPUGenInstrInfo {
102102
public:
103103
unsigned buildExtractSubReg(MachineBasicBlock::iterator MI,
104104
MachineRegisterInfo &MRI,
105-
MachineOperand &SuperReg,
105+
const MachineOperand &SuperReg,
106106
const TargetRegisterClass *SuperRC,
107107
unsigned SubIdx,
108108
const TargetRegisterClass *SubRC) const;
109-
MachineOperand buildExtractSubRegOrImm(MachineBasicBlock::iterator MI,
110-
MachineRegisterInfo &MRI,
111-
MachineOperand &SuperReg,
112-
const TargetRegisterClass *SuperRC,
113-
unsigned SubIdx,
114-
const TargetRegisterClass *SubRC) const;
109+
MachineOperand buildExtractSubRegOrImm(
110+
MachineBasicBlock::iterator MI, MachineRegisterInfo &MRI,
111+
const MachineOperand &SuperReg, const TargetRegisterClass *SuperRC,
112+
unsigned SubIdx, const TargetRegisterClass *SubRC) const;
113+
115114
private:
116115
void swapOperands(MachineInstr &Inst) const;
117116

0 commit comments

Comments
 (0)