Skip to content

Commit 3c9236c

Browse files
brunodf-snpsnikic
authored andcommitted
[LoopVersioningLICM] add comment regarding dubious check (NFC)
1 parent 65d3548 commit 3c9236c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

llvm/lib/Transforms/Scalar/LoopVersioningLICM.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,11 @@ bool LoopVersioningLICM::legalLoopMemoryAccesses() {
266266
for (const auto &A : AS) {
267267
Value *Ptr = A.getValue();
268268
// Alias tracker should have pointers of same data type.
269+
//
270+
// FIXME: check no longer effective since opaque pointers?
271+
// If the intent is to check that the memory accesses use the
272+
// same data type (such that LICM can promote them), then we
273+
// can no longer see this from the pointer value types.
269274
TypeCheck = (TypeCheck && (SomePtr->getType() == Ptr->getType()));
270275
}
271276
// At least one alias tracker should have pointers of same data type.

0 commit comments

Comments
 (0)