Comments

Author: Pierre-vh

llvm/include/llvm/Support/Compiler.h

@@ -278,7 +278,7 @@
 #define LLVM_ATTRIBUTE_RETURNS_NONNULL
 #endif
 
-/// LLVM_ATTRIBUTE_RESTRICT- Annotates a pointer to tell the compiler that
+/// LLVM_ATTRIBUTE_RESTRICT - Annotates a pointer to tell the compiler that
 /// it is not aliased in the current scope.
 #if defined(__clang__) || defined(__GNUC__) || defined(_MSC_VER)
 #define LLVM_ATTRIBUTE_RESTRICT __restrict

llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTable.cpp

@@ -1591,6 +1591,9 @@ bool MemoryAlignmentPredicateMatcher::isIdentical(
 
 void MemoryAlignmentPredicateMatcher::emitPredicateOpcodes(
     MatchTable &Table, RuleMatcher &Rule) const {
+  // TODO: we could support more, just need to emit the right opcode or switch
+  // to log alignment.
+  assert(MinAlign < 256);
   Table << MatchTable::Opcode("GIM_CheckMemoryAlignment")
         << MatchTable::Comment("MI") << MatchTable::ULEB128Value(InsnVarID)
         << MatchTable::Comment("MMO") << MatchTable::ULEB128Value(MMOIdx)