Skip to content

Commit 3d3b0bc

Browse files
slydimanlabath
andauthored
[lldb] Disable find-module.test in case of a remote target (#94165)
The target arch is `i386-pc-windows` after loading the dump. It updates to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218 ``` GetTarget().MergeArchitecture(module->GetArchitecture()); ``` But in case of the remote target (`remote-linux`) and the `Windows host` lldb executed the following commands at the beginning ``` platform select remote-linux platform connect connect://<ip>:<port> ``` and then the target arch is `i386-pc-windows-msvc` immediately after loading the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it to `i386-pc-windows-gnu` when the module arch is `i386-pc-windows-gnu`. --------- Co-authored-by: Pavel Labath <[email protected]>
1 parent 5be43db commit 3d3b0bc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lldb/test/Shell/Minidump/Windows/find-module.test

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
Test that we correctly find a PE/COFF file in our executable search path, and
22
use it when opening minidumps.
33

4+
XFAIL: remote{{.*}}
5+
46
RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe
57
RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp
68
RUN: %lldb -O "settings set target.exec-search-paths %T" \

0 commit comments

Comments
 (0)