Skip to content

Commit 3db5db9

Browse files
committed
[lit] Fix f254bbf FileCheck patterns
Handle the case when shell quotes are not necessary.
1 parent 48a8262 commit 3db5db9

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

llvm/utils/lit/tests/shtest-env.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585

8686
# CHECK: FAIL: shtest-env :: env-calls-not-builtin.txt ({{[^)]*}})
8787
# CHECK: env -u FOO BAR=3 not rm {{.+}}.no-such-file
88-
# CHECK: # executed command: env -u FOO BAR=3 not rm {{.+}}.no-such-file{{.+}}
88+
# CHECK: # executed command: env -u FOO BAR=3 not rm {{.+}}.no-such-file{{.*}}
8989
# CHECK: # | Error: 'env' cannot call 'rm'
9090
# CHECK: # error: command failed with exit status: {{.*}}
9191

llvm/utils/lit/tests/shtest-not.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106

107107
# CHECK: FAIL: shtest-not :: not-calls-env-builtin.txt {{.*}}
108108
# CHECK: not --crash env -u FOO BAR=3 rm {{.*}}.no-such-file
109-
# CHECK: # executed command: not --crash env -u FOO BAR=3 rm {{.+}}.no-such-file{{.+}}
109+
# CHECK: # executed command: not --crash env -u FOO BAR=3 rm {{.+}}.no-such-file{{.*}}
110110
# CHECK: # | Error: 'env' cannot call 'rm'
111111
# CHECK: # error: command failed with exit status: {{.*}}
112112

llvm/utils/lit/tests/shtest-shell.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@
238238
# CHECK-NOT: error
239239

240240
# CHECK: diff -u {{.*}}.foo {{.*}}.bar | FileCheck {{.*}} && false || true
241-
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.+}} {{.+}}.bar{{.+}}
241+
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.*}} {{.+}}.bar{{.*}}
242242
# CHECK-NEXT: # note: command had no output on stdout or stderr
243243
# CHECK-NEXT: # error: command failed with exit status: 1
244244
# CHECK-NEXT: # executed command: FileCheck
@@ -253,8 +253,8 @@
253253
# CHECK-NOT: error
254254

255255
# CHECK: cat {{.*}}.bar | diff -u {{.*}}.foo - && false || true
256-
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.+}}
257-
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.+}} -
256+
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.*}}
257+
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.*}} -
258258
# CHECK-NEXT: # .---command stdout{{-*}}
259259
# CHECK: # | @@
260260
# CHECK-NEXT: # | -foo
@@ -264,8 +264,8 @@
264264
# CHECK-NEXT: # executed command: true
265265

266266
# CHECK: cat {{.*}}.bar | diff -u - {{.*}}.foo && false || true
267-
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.+}}
268-
# CHECK-NEXT: # executed command: diff -u - {{.+}}.foo{{.+}}
267+
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.*}}
268+
# CHECK-NEXT: # executed command: diff -u - {{.+}}.foo{{.*}}
269269
# CHECK-NEXT: # .---command stdout{{-*}}
270270
# CHECK: # | @@
271271
# CHECK-NEXT: # | -bar
@@ -279,8 +279,8 @@
279279
# CHECK-NOT: error
280280

281281
# CHECK: cat {{.*}}.bar | diff -u {{.*}}.foo - | FileCheck {{.*}}
282-
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.+}}
283-
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.+}} -
282+
# CHECK-NEXT: # executed command: cat {{.+}}.bar{{.*}}
283+
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.*}} -
284284
# CHECK-NEXT: note: command had no output on stdout or stderr
285285
# CHECK-NEXT: error: command failed with exit status: 1
286286
# CHECK-NEXT: # executed command: FileCheck
@@ -427,7 +427,7 @@
427427
# CHECK: *** TEST 'shtest-shell :: diff-unified.txt' FAILED ***
428428

429429
# CHECK: diff -u {{.*}}.foo {{.*}}.bar && false || true
430-
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.+}} {{.+}}.bar{{.+}}
430+
# CHECK-NEXT: # executed command: diff -u {{.+}}.foo{{.*}} {{.+}}.bar{{.*}}
431431
# CHECK-NEXT: # .---command stdout{{-*}}
432432
# CHECK: # | @@ {{.*}} @@
433433
# CHECK-NEXT: # | 3
@@ -443,7 +443,7 @@
443443
# CHECK-NEXT: # executed command: true
444444

445445
# CHECK: diff -U 2 {{.*}}.foo {{.*}}.bar && false || true
446-
# CHECK-NEXT: # executed command: diff -U 2 {{.+}}.foo{{.+}} {{.+}}.bar{{.+}}
446+
# CHECK-NEXT: # executed command: diff -U 2 {{.+}}.foo{{.*}} {{.+}}.bar{{.*}}
447447
# CHECK-NEXT: # .---command stdout{{-*}}
448448
# CHECK: # | @@ {{.*}} @@
449449
# CHECK-NEXT: # | 4
@@ -457,7 +457,7 @@
457457
# CHECK-NEXT: # executed command: true
458458

459459
# CHECK: diff -U4 {{.*}}.foo {{.*}}.bar && false || true
460-
# CHECK-NEXT: # executed command: diff -U4 {{.+}}.foo{{.+}} {{.+}}.bar{{.+}}
460+
# CHECK-NEXT: # executed command: diff -U4 {{.+}}.foo{{.*}} {{.+}}.bar{{.*}}
461461
# CHECK-NEXT: # .---command stdout{{-*}}
462462
# CHECK: # | @@ {{.*}} @@
463463
# CHECK-NEXT: # | 2

0 commit comments

Comments
 (0)