[llvm-dis][NFC] Avoid unnecessary copies while iterating (#109860)

AmrDeveloper · web-flow · commit 3e0d31c97cf2 · 2024-09-26T16:39:59.000+02:00
Avoid unnecessary copies while iterating on input files
diff --git a/llvm/tools/llvm-dis/llvm-dis.cpp b/llvm/tools/llvm-dis/llvm-dis.cpp
@@ -203,7 +203,7 @@ int main(int argc, char **argv) {
     return 1;
   }
 
-  for (std::string InputFilename : InputFilenames) {
+  for (const auto &InputFilename : InputFilenames) {
     ErrorOr<std::unique_ptr<MemoryBuffer>> BufferOrErr =
         MemoryBuffer::getFileOrSTDIN(InputFilename);
     if (std::error_code EC = BufferOrErr.getError()) {

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ int main(int argc, char **argv) {`
`203`	`203`	`return 1;`
`204`	`204`	`}`
`205`	`205`
`206`		`- for (std::string InputFilename : InputFilenames) {`
	`206`	`+ for (const auto &InputFilename : InputFilenames) {`
`207`	`207`	`ErrorOr<std::unique_ptr<MemoryBuffer>> BufferOrErr =`
`208`	`208`	`MemoryBuffer::getFileOrSTDIN(InputFilename);`
`209`	`209`	`if (std::error_code EC = BufferOrErr.getError()) {`