Address review comments

Author: marbre

mlir/include/mlir/Conversion/FuncToEmitC/FuncToEmitCPass.h

@@ -14,11 +14,8 @@
 namespace mlir {
 class Pass;
 
-#define GEN_PASS_DECL_FUNCTOEMITC
+#define GEN_PASS_DECL_CONVERTFUNCTOEMITC
 #include "mlir/Conversion/Passes.h.inc"
-
-std::unique_ptr<Pass> createConvertFuncToEmitC();
-
 } // namespace mlir
 
 #endif // MLIR_CONVERSION_FUNCTOEMITC_FUNCTOEMITCPASS_H

mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp

@@ -34,7 +34,7 @@ class CallOpConversion final : public OpConversionPattern<func::CallOp> {
     // Multiple results func was not converted to `emitc.func`.
     if (callOp.getNumResults() > 1)
       return rewriter.notifyMatchFailure(
-          callOp, "Only functions with zero or one result can be converted");
+          callOp, "only functions with zero or one result can be converted");
 
     rewriter.replaceOpWithNewOp<emitc::CallOp>(
         callOp,
@@ -55,11 +55,11 @@ class FuncOpConversion final : public OpConversionPattern<func::FuncOp> {
 
     if (funcOp.getFunctionType().getNumResults() > 1)
       return rewriter.notifyMatchFailure(
-          funcOp, "Only functions with zero or one result can be converted");
+          funcOp, "only functions with zero or one result can be converted");
 
     if (funcOp.isDeclaration())
       return rewriter.notifyMatchFailure(funcOp,
-                                         "Declarations cannot be converted");
+                                         "declarations cannot be converted");
 
     // Create the converted `emitc.func` op.
     emitc::FuncOp newFuncOp = rewriter.create<emitc::FuncOp>(
@@ -95,7 +95,7 @@ class ReturnOpConversion final : public OpConversionPattern<func::ReturnOp> {
                   ConversionPatternRewriter &rewriter) const override {
     if (returnOp.getNumOperands() > 1)
       return rewriter.notifyMatchFailure(
-          returnOp, "Only zero or one operand is supported");
+          returnOp, "only zero or one operand is supported");
 
     rewriter.replaceOpWithNewOp<emitc::ReturnOp>(
         returnOp,
@@ -112,7 +112,5 @@ class ReturnOpConversion final : public OpConversionPattern<func::ReturnOp> {
 void mlir::populateFuncToEmitCPatterns(RewritePatternSet &patterns) {
   MLIRContext *ctx = patterns.getContext();
 
-  patterns.add<CallOpConversion>(ctx);
-  patterns.add<FuncOpConversion>(ctx);
-  patterns.add<ReturnOpConversion>(ctx);
+  patterns.add<CallOpConversion, FuncOpConversion, ReturnOpConversion>(ctx);
 }

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

@@ -349,6 +349,7 @@ LogicalResult ForOp::verifyRegions() {
 
   return success();
 }
+
 //===----------------------------------------------------------------------===//
 // CallOp
 //===----------------------------------------------------------------------===//