Skip to content

Commit 3f393a1

Browse files
committed
check against errno
1 parent 363a917 commit 3f393a1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

libc/test/src/sys/mman/linux/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,4 +198,6 @@ add_libc_unittest(
198198
libc.include.signal
199199
libc.src.stdlib.exit
200200
libc.src.__support.OSUtil.osutil
201-
libc.src.__support.threads.sleep)
201+
libc.src.__support.threads.sleep
202+
libc.test.UnitTest.ErrnoSetterMatcher
203+
)

libc/test/src/sys/mman/linux/process_mrelease_test.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@
1414
#include "src/sys/mman/process_mrelease.h"
1515
#include "src/unistd/close.h"
1616
#include "src/unistd/fork.h"
17+
#include "test/UnitTest/ErrnoSetterMatcher.h"
1718
#include "test/UnitTest/LibcTest.h"
1819

1920
#include <sys/syscall.h>
2021

22+
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
23+
2124
int pidfd_open(pid_t pid, unsigned int flags) {
2225
return LIBC_NAMESPACE::syscall_impl(SYS_pidfd_open, pid, flags);
2326
}
@@ -40,7 +43,7 @@ TEST(LlvmLibcMProcessMReleaseTest, NoError) {
4043
// Send SIGKILL to child process
4144
LIBC_NAMESPACE::kill(child_pid, SIGKILL);
4245

43-
EXPECT_EQ(LIBC_NAMESPACE::process_mrelease(pidfd, 0), 0);
46+
EXPECT_THAT(LIBC_NAMESPACE::process_mrelease(pidfd, 0), Succeeds());
4447

4548
LIBC_NAMESPACE::close(pidfd);
4649
}
@@ -60,13 +63,12 @@ TEST(LlvmLibcMProcessMReleaseTest, ErrorNotKilled) {
6063
int pidfd = pidfd_open(child_pid, 0);
6164
EXPECT_GE(pidfd, 0);
6265

63-
ASSERT_EQ(LIBC_NAMESPACE::process_mrelease(pidfd, 0), EINVAL);
66+
EXPECT_THAT(LIBC_NAMESPACE::process_mrelease(pidfd, 0), Fails(EINVAL));
6467

6568
LIBC_NAMESPACE::close(pidfd);
6669
}
6770
}
6871

6972
TEST(LlvmLibcMProcessMReleaseTest, ErrorNonExistingPidfd) {
70-
71-
ASSERT_EQ(LIBC_NAMESPACE::process_mrelease(-1, 0), EBADF);
73+
EXPECT_THAT(LIBC_NAMESPACE::process_mrelease(-1, 0), Fails(EBADF));
7274
}

0 commit comments

Comments
 (0)