Address comments (round 2)

- Remove passing as `const &` for the `llvm::function_ref`.
- Fix ordering of interface methods.

Author: MaheshRavishankar

mlir/include/mlir/Dialect/SCF/IR/SCFOps.td

@@ -135,10 +135,11 @@ def ExecuteRegionOp : SCF_Op<"execute_region", [
 
 def ForOp : SCF_Op<"for",
       [AutomaticAllocationScope, DeclareOpInterfaceMethods<LoopLikeOpInterface,
-       ["getInitsMutable", "getRegionIterArgs", "getSingleInductionVar", 
-        "getSingleLowerBound", "getSingleStep", "getSingleUpperBound",
-        "getYieldedValuesMutable", "getLoopResults", "promoteIfSingleIteration",
-        "replaceWithAdditionalYields", "yieldTiledValuesAndReplace"]>,
+       ["getInitsMutable", "getLoopResults", "getRegionIterArgs",
+        "getSingleInductionVar", "getSingleLowerBound", "getSingleStep",
+        "getSingleUpperBound", "getYieldedValuesMutable",
+        "promoteIfSingleIteration", "replaceWithAdditionalYields",
+        "yieldTiledValuesAndReplace"]>,
        AllTypesMatch<["lowerBound", "upperBound", "step"]>,
        ConditionallySpeculatable,
        DeclareOpInterfaceMethods<RegionBranchOpInterface,

mlir/include/mlir/Interfaces/LoopLikeInterface.td

@@ -263,7 +263,7 @@ def LoopLikeOpInterface : OpInterface<"LoopLikeOpInterface"> {
       /*methodName=*/"yieldTiledValuesAndReplace",
       /*args=*/(ins "::mlir::RewriterBase &":$rewriter,
                     "::mlir::ValueRange":$newInitOperands,
-                    "const ::mlir::YieldTiledValuesFn &":$yieldTiledValuesFn),
+                    "::mlir::YieldTiledValuesFn":$yieldTiledValuesFn),
       /*methodBody=*/"",
       /*defaultImplementation=*/[{
         return ::mlir::failure();

mlir/lib/Dialect/SCF/IR/SCF.cpp

@@ -588,9 +588,10 @@ ForOp::replaceWithAdditionalYields(RewriterBase &rewriter,
   return cast<LoopLikeOpInterface>(newLoop.getOperation());
 }
 
-FailureOr<LoopLikeOpInterface> ForOp::yieldTiledValuesAndReplace(
-    RewriterBase &rewriter, ValueRange newInitOperands,
-    const YieldTiledValuesFn &yieldTiledValuesFn) {
+FailureOr<LoopLikeOpInterface>
+ForOp::yieldTiledValuesAndReplace(RewriterBase &rewriter,
+                                  ValueRange newInitOperands,
+                                  YieldTiledValuesFn yieldTiledValuesFn) {
   OpBuilder::InsertionGuard g(rewriter);
   rewriter.setInsertionPoint(getOperation());
 
@@ -691,9 +692,10 @@ MutableArrayRef<OpOperand> ForallOp::getInitsMutable() {
   return getOutputsMutable();
 }
 
-FailureOr<LoopLikeOpInterface> ForallOp::yieldTiledValuesAndReplace(
-    RewriterBase &rewriter, ValueRange newInitOperands,
-    const YieldTiledValuesFn &yieldTiledValuesFn) {
+FailureOr<LoopLikeOpInterface>
+ForallOp::yieldTiledValuesAndReplace(RewriterBase &rewriter,
+                                     ValueRange newInitOperands,
+                                     YieldTiledValuesFn yieldTiledValuesFn) {
   OpBuilder::InsertionGuard g(rewriter);
   rewriter.setInsertionPoint(getOperation());
   auto inits = llvm::to_vector(getOutputs());