Skip to content

Commit 3f7f446

Browse files
authored
[llvm-profgen] Remove temporary perf script files (#86668)
The temporary perf script files converted from perf data will occupy lots of space for large project. This patch removes them when llvm-profgen exits normally or receives signals.
1 parent dc39028 commit 3f7f446

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

llvm/tools/llvm-profgen/PerfReader.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "llvm/DebugInfo/Symbolize/SymbolizableModule.h"
1212
#include "llvm/Support/FileSystem.h"
1313
#include "llvm/Support/Process.h"
14+
#include "llvm/Support/ToolOutputFile.h"
1415

1516
#define DEBUG_TYPE "perf-reader"
1617

@@ -375,6 +376,9 @@ PerfScriptReader::convertPerfDataToTrace(ProfiledBinary *Binary,
375376
StringRef(ErrorFile)}; // Stderr
376377
sys::ExecuteAndWait(PerfPath, ScriptMMapArgs, std::nullopt, Redirects);
377378

379+
PerfScriptReader::TempFileCleanups.emplace_back(PerfTraceFile);
380+
PerfScriptReader::TempFileCleanups.emplace_back(ErrorFile);
381+
378382
// Collect the PIDs
379383
TraceStream TraceIt(PerfTraceFile);
380384
std::string PIDs;
@@ -1220,5 +1224,7 @@ void PerfScriptReader::parsePerfTraces() {
12201224
writeUnsymbolizedProfile(OutputFilename);
12211225
}
12221226

1227+
SmallVector<CleanupInstaller, 2> PerfScriptReader::TempFileCleanups;
1228+
12231229
} // end namespace sampleprof
12241230
} // end namespace llvm

llvm/tools/llvm-profgen/PerfReader.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ using namespace llvm;
2121
using namespace sampleprof;
2222

2323
namespace llvm {
24+
25+
class CleanupInstaller;
26+
2427
namespace sampleprof {
2528

2629
// Stream based trace line iterator
@@ -604,6 +607,11 @@ class PerfScriptReader : public PerfReaderBase {
604607
// Extract perf script type by peaking at the input
605608
static PerfContent checkPerfScriptType(StringRef FileName);
606609

610+
// Cleanup installers for temporary files created by perf script command.
611+
// Those files will be automatically removed when running destructor or
612+
// receiving signals.
613+
static SmallVector<CleanupInstaller, 2> TempFileCleanups;
614+
607615
protected:
608616
// The parsed MMap event
609617
struct MMapEvent {

0 commit comments

Comments
 (0)