Skip to content

Commit 3fbd0ec

Browse files
love1angelldionne
andauthored
[libc++] Update the status for LWG3120 (#116772)
The current implementation already have an __initial_descriptor which saves the initial state. When release() is called, we will reset the __initial_descriptor.__cur_ pointer. This patch also updates the status of LWG3120. Closes #104274 --------- Co-authored-by: Louis Dionne <[email protected]>
1 parent f89129a commit 3fbd0ec

File tree

2 files changed

+52
-1
lines changed

2 files changed

+52
-1
lines changed

libcxx/docs/Status/Cxx23Issues.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"`LWG2731 <https://wg21.link/LWG2731>`__","Existence of ``lock_guard<MutexTypes...>::mutex_type`` typedef unclear","2020-11 (Virtual)","|Complete|","5",""
1515
"`LWG2743 <https://wg21.link/LWG2743>`__","P0083R3 ``node_handle`` private members missing ""exposition only"" comment","2020-11 (Virtual)","|Nothing To Do|","",""
1616
"`LWG2820 <https://wg21.link/LWG2820>`__","Clarify ``<cstdint>`` macros","2020-11 (Virtual)","|Nothing To Do|","",""
17-
"`LWG3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","2020-11 (Virtual)","","",""
17+
"`LWG3120 <https://wg21.link/LWG3120>`__","Unclear behavior of ``monotonic_buffer_resource::release()``","2020-11 (Virtual)","|Complete|","16",""
1818
"`LWG3170 <https://wg21.link/LWG3170>`__","``is_always_equal`` added to ``std::allocator`` makes the standard library treat derived types as always equal","2020-11 (Virtual)","|Complete|","18",""
1919
"`LWG3036 <https://wg21.link/LWG3036>`__","``polymorphic_allocator::destroy`` is extraneous","2020-11 (Virtual)","|Nothing To Do|","","Reverted by P2875R4"
2020
"`LWG3171 <https://wg21.link/LWG3171>`__","LWG2989 breaks ``directory_entry`` stream insertion","2020-11 (Virtual)","|Complete|","14",""
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
//===----------------------------------------------------------------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
9+
// REQUIRES: std-at-least-c++17
10+
// UNSUPPORTED: availability-pmr-missing
11+
12+
// <memory_resource>
13+
14+
// class monotonic_buffer_resource
15+
16+
// This test checks the behavior required by LWG3120.
17+
18+
#include <memory_resource>
19+
#include <cassert>
20+
21+
#include "count_new.h"
22+
#include "test_macros.h"
23+
24+
int main(int, char**) {
25+
{
26+
{
27+
// When ctor with a next buffer size. After release(), check whether the next buffer size has been reset after release()
28+
constexpr size_t expect_next_buffer_size = 512;
29+
std::pmr::monotonic_buffer_resource mr{nullptr, expect_next_buffer_size, std::pmr::new_delete_resource()};
30+
31+
for (int i = 0; i < 100; ++i) {
32+
(void)mr.allocate(1);
33+
mr.release();
34+
ASSERT_WITH_LIBRARY_INTERNAL_ALLOCATIONS(globalMemCounter.checkLastNewSizeGe(expect_next_buffer_size));
35+
}
36+
}
37+
{
38+
// Check whether the offset of the initial buffer has been reset after release()
39+
constexpr size_t buffer_size = 100;
40+
char buffer[buffer_size];
41+
std::pmr::monotonic_buffer_resource mr{buffer, buffer_size, std::pmr::null_memory_resource()};
42+
43+
mr.release();
44+
auto expect_mem_start = mr.allocate(60);
45+
mr.release();
46+
auto ths_mem_start = mr.allocate(60);
47+
assert(expect_mem_start == ths_mem_start);
48+
}
49+
}
50+
return 0;
51+
}

0 commit comments

Comments
 (0)