[LLDB][NativePDB] Fix use-after-free error detected by asan.

ZequanWu · ZequanWu · commit 4004f655ceb9 · 2024-01-04T12:32:40.000-05:00
diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
@@ -2265,7 +2265,8 @@ void SymbolFileNativePDB::BuildParentMap() {
   }
   for (TypeIndex fwd : fwd_keys) {
     TypeIndex full = forward_to_full[fwd];
-    m_parent_types[full] = m_parent_types[fwd];
+    TypeIndex parent_idx = m_parent_types[fwd];
+    m_parent_types[full] = parent_idx;
   }
   for (TypeIndex full : full_keys) {
     TypeIndex fwd = full_to_forward[full];

Original file line number	Diff line number	Diff line change
`@@ -2265,7 +2265,8 @@ void SymbolFileNativePDB::BuildParentMap() {`
`2265`	`2265`	`}`
`2266`	`2266`	`for (TypeIndex fwd : fwd_keys) {`
`2267`	`2267`	`TypeIndex full = forward_to_full[fwd];`
`2268`		`- m_parent_types[full] = m_parent_types[fwd];`
	`2268`	`+ TypeIndex parent_idx = m_parent_types[fwd];`
	`2269`	`+ m_parent_types[full] = parent_idx;`
`2269`	`2270`	`}`
`2270`	`2271`	`for (TypeIndex full : full_keys) {`
`2271`	`2272`	`TypeIndex fwd = full_to_forward[full];`