Skip to content

Commit 4075dda

Browse files
authored
[libc++] Run clang-tidy only once per header (#121436)
There doesn't seem to be much of a reason to run clang-tidy twice per headers, and running it only once makes the test a few seconds faster.
1 parent 40ac34c commit 4075dda

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

libcxx/.clang-tidy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ Checks: >
55
bugprone-stringview-nullptr,
66
bugprone-use-after-move,
77
8+
libcpp-*,
9+
810
llvm-include-order,
911
llvm-namespace-comment,
1012

libcxx/test/libcxx/clang_tidy.gen.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
{lit_header_undeprecations.get(header, '')}
3434
3535
// TODO: run clang-tidy with modules enabled once they are supported
36-
// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- %{{compile_flags}} -fno-modules
37-
// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --config-file=%{{libcxx-dir}}/.clang-tidy -- -Wweak-vtables %{{compile_flags}} -fno-modules
36+
// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --config-file=%{{libcxx-dir}}/.clang-tidy --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- -Wweak-vtables %{{compile_flags}} -fno-modules
3837
3938
#include <{header}>
4039
""")

0 commit comments

Comments
 (0)