Skip to content

Commit 42f3ab1

Browse files
committed
Add TODO for maxnumf and minnumf
1 parent 677ada2 commit 42f3ab1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ static ReductionKind getReductionKind(Operation *op) {
5252
// Floating-point operations.
5353
.Case([](arith::AddFOp op) { return ReductionKind::Sum; })
5454
.Case([](arith::MulFOp op) { return ReductionKind::Product; })
55+
// TODO: handle maxnumf and minnumf.
5556
.Case([](arith::MaximumFOp op) { return ReductionKind::Max; })
5657
.Case([](arith::MinimumFOp op) { return ReductionKind::Min; })
5758
// Integer operations.

0 commit comments

Comments
 (0)