Skip to content

Commit 437366b

Browse files
authored
Adjust MSVC version range for ARM64 build performance regression (#90731)
This is follow up for #65215 Mentioned regression was fixed in MSVC 19.39 (VS 17.9.0), so it makes sense to not apply fix for that (and newer) compiler versions. Same as original change, this patch is narrowly scoped to not affect any other compiler.
1 parent 9267f8f commit 437366b

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

clang/lib/CodeGen/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ set(LLVM_LINK_COMPONENTS
3939
# our goal is to disable the /Og flag while retaining the other optimizations from the /O1|/O2 set
4040
if(MSVC AND NOT CMAKE_CXX_COMPILER_ID MATCHES Clang
4141
AND MSVC_VERSION VERSION_GREATER_EQUAL 1932
42+
AND MSVC_VERSION VERSION_LESS 1939
4243
AND CMAKE_SYSTEM_PROCESSOR MATCHES "ARM64")
4344

4445
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)

clang/lib/Tooling/Inclusions/Stdlib/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# our goal is to disable the /Og flag while retaining the other optimizations from the /O1|/O2 set
55
if(MSVC AND NOT CMAKE_CXX_COMPILER_ID MATCHES Clang
66
AND MSVC_VERSION VERSION_GREATER_EQUAL 1932
7+
AND MSVC_VERSION VERSION_LESS 1939
78
AND CMAKE_SYSTEM_PROCESSOR MATCHES "ARM64")
89

910
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)

0 commit comments

Comments
 (0)