Silence an illegal conversion warning in MSVC; NFC

AaronBallman · AaronBallman · commit 43ca99a2516f · 2023-08-28T08:06:03.000-04:00
The code previously required two levels of conversion, one from
SmallString to StringRef and one from StringRef to Regex. This made the
implicit conversion to StringRef be explicit instead.
diff --git a/clang-tools-extra/clang-tidy/GlobList.cpp b/clang-tools-extra/clang-tidy/GlobList.cpp
@@ -39,7 +39,7 @@ static llvm::Regex consumeGlob(StringRef &GlobList) {
     RegexText.push_back(C);
   }
   RegexText.push_back('$');
-  return {RegexText};
+  return {RegexText.str()};
 }
 
 GlobList::GlobList(StringRef Globs, bool KeepNegativeGlobs /* =true */) {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ static llvm::Regex consumeGlob(StringRef &GlobList) {`
`39`	`39`	`RegexText.push_back(C);`
`40`	`40`	`}`
`41`	`41`	`RegexText.push_back('$');`
`42`		`- return {RegexText};`
	`42`	`+ return {RegexText.str()};`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`GlobList::GlobList(StringRef Globs, bool KeepNegativeGlobs /* =true */) {`