Skip to content

Commit 44059b8

Browse files
committed
Address simple review comments
1 parent 51eb02e commit 44059b8

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

lldb/source/Plugins/SystemRuntime/MacOSX/AbortWithPayloadFrameRecognizer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ AbortWithPayloadFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame_sp) {
5656
static constexpr llvm::StringLiteral info_key("abort_with_payload");
5757

5858
Log *log = GetLog(LLDBLog::SystemRuntime);
59-
59+
6060
if (!frame_sp) {
6161
LLDB_LOG(log, "abort_with_payload recognizer: invalid frame.");
6262
return {};
@@ -197,8 +197,8 @@ AbortWithPayloadFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame_sp) {
197197
abort_dict_sp->AddStringItem(reason_key, reason_string);
198198
abort_dict_sp->AddIntegerItem(flags_key, flags_val);
199199

200-
// This will overwrite the abort_with_payload information in the dictionary
201-
// already. But we can only crash on abort_with_payload once, so that
200+
// This will overwrite the abort_with_payload information in the dictionary
201+
// already. But we can only crash on abort_with_payload once, so that
202202
// shouldn't matter.
203203
process->GetExtendedCrashInfoDict()->AddItem(info_key, abort_dict_sp);
204204

lldb/test/API/lang/cpp/std-invoke-recognizer/TestStdInvokeRecognizer.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class LibCxxStdFunctionRecognizerTestCase(TestBase):
99

1010
@add_test_categories(["libc++"])
1111
def test_frame_recognizer(self):
12-
"""Test that implementation details details of `std::invoke`"""
12+
"""Test that implementation details of `std::invoke` are hidden"""
1313
self.build()
1414
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
1515
self, "// break here", lldb.SBFileSpec("main.cpp")
@@ -22,16 +22,13 @@ def test_frame_recognizer(self):
2222
for f in ["print_num", "add", "PrintAdder"]
2323
)
2424
)
25-
print(thread.GetFrameAtIndex(0).GetFunctionName())
2625
# Skip all hidden frames
2726
frame_id = 1
2827
while (
2928
frame_id < thread.GetNumFrames()
3029
and thread.GetFrameAtIndex(frame_id).IsHidden()
3130
):
32-
print(thread.GetFrameAtIndex(frame_id).GetFunctionName())
3331
frame_id = frame_id + 1
34-
print(thread.GetFrameAtIndex(frame_id).GetFunctionName())
3532
# Expect `std::invoke` to be the direct parent
3633
self.assertIn(
3734
"::invoke", thread.GetFrameAtIndex(frame_id).GetFunctionName()

0 commit comments

Comments
 (0)