address comments

Chen Zheng · Chen Zheng · commit 44cbb15ecce5 · 2023-11-19T20:36:35.000-05:00
diff --git a/llvm/lib/Object/XCOFFObjectFile.cpp b/llvm/lib/Object/XCOFFObjectFile.cpp
@@ -1288,7 +1288,7 @@ Expected<bool> XCOFFSymbolRef::isFunction() const {
   if (CsectAuxRef.getSymbolType() == XCOFF::XTY_LD)
     return true;
 
-  return false;
+  return createError("csect symbol has no valid symbol type.");
 }
 
 bool XCOFFSymbolRef::isCsectSymbol() const {

Original file line number	Diff line number	Diff line change
`@@ -1288,7 +1288,7 @@ Expected<bool> XCOFFSymbolRef::isFunction() const {`
`1288`	`1288`	`if (CsectAuxRef.getSymbolType() == XCOFF::XTY_LD)`
`1289`	`1289`	`return true;`
`1290`	`1290`
`1291`		`- return false;`
	`1291`	`+ return createError("csect symbol has no valid symbol type.");`
`1292`	`1292`	`}`
`1293`	`1293`
`1294`	`1294`	`bool XCOFFSymbolRef::isCsectSymbol() const {`