must not cache temporaries

zyx-billy · zyx-billy · commit 450126997254 · 2024-04-14T16:12:00.000-07:00
diff --git a/mlir/lib/Target/LLVMIR/DebugTranslation.cpp b/mlir/lib/Target/LLVMIR/DebugTranslation.cpp
@@ -352,7 +352,8 @@ llvm::DINode *DebugTranslation::translate(DINodeAttr attr) {
                      DISubroutineTypeAttr>(
                    [&](auto attr) { return translateImpl(attr); });
 
-  attrToNode.insert({attr, node});
+  if (!node->isTemporary())
+    attrToNode.insert({attr, node});
   return node;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,8 @@ llvm::DINode *DebugTranslation::translate(DINodeAttr attr) {`
`352`	`352`	`DISubroutineTypeAttr>(`
`353`	`353`	`[&](auto attr) { return translateImpl(attr); });`
`354`	`354`
`355`		`- attrToNode.insert({attr, node});`
	`355`	`+ if (!node->isTemporary())`
	`356`	`+ attrToNode.insert({attr, node});`
`356`	`357`	`return node;`
`357`	`358`	`}`
`358`	`359`