Print more descriptive error message when trying to link a global with appending linkage

arrowd · arrowd · commit 454648963ccb · 2024-02-10T14:37:01.000+03:00
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -2929,7 +2929,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {
     return true;
   }
 
-  report_fatal_error("unknown special variable");
+  report_fatal_error("unknown special variable with appending linkage");
 }
 
 /// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each
diff --git a/llvm/test/CodeGen/X86/AppendingLinkage.ll b/llvm/test/CodeGen/X86/AppendingLinkage.ll
@@ -1,4 +1,4 @@
 ; RUN: not --crash llc < %s -mtriple=i686-- 2>&1 | FileCheck %s
 
-; CHECK: unknown special variable
+; CHECK: unknown special variable with appending linkage
 @foo = appending constant [1 x i32 ]zeroinitializer

Original file line number	Diff line number	Diff line change
`@@ -2929,7 +2929,7 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {`
`2929`	`2929`	`return true;`
`2930`	`2930`	`}`
`2931`	`2931`
`2932`		`- report_fatal_error("unknown special variable");`
	`2932`	`+ report_fatal_error("unknown special variable with appending linkage");`
`2933`	`2933`	`}`
`2934`	`2934`
`2935`	`2935`	`/// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each`