Skip to content

Commit 46ec025

Browse files
committed
[clang][cli] NFC: Move prefix to the front of BoolOption
The prefix used to be the last (optional) argument to BoolOption. This decision was made with the expectation that only few command line options would need to pass it explicitly instead of using Bool{F,G}Option. It turns out that a considerable number of options don't conform to Bool{F,G}Option and need to provide the prefix anyways. This sometimes requires to explicitly pass `BothFlags<[]>`. This patch makes prefix the first parameter, so it now directly precedes the spelling base string. Now 8 options dropped `BothFlags<[]>` and only two options (`pthread` and `emit_llvm_uselists`) need to pass an empty prefix. Reviewed By: dexonsmith Differential Revision: https://reviews.llvm.org/D95221
1 parent 8fbc143 commit 46ec025

File tree

1 file changed

+74
-79
lines changed

1 file changed

+74
-79
lines changed

0 commit comments

Comments
 (0)