[ExecutionEngine] Avoid repeated hash lookups (NFC) (#110451)

kazutakahirata · web-flow · commit 47b22301da44 · 2024-09-30T06:48:00.000-07:00
diff --git a/llvm/lib/ExecutionEngine/Orc/COFFPlatform.cpp b/llvm/lib/ExecutionEngine/Orc/COFFPlatform.cpp
@@ -521,10 +521,8 @@ void COFFPlatform::pushInitializersLoop(PushInitializersSendResultFn SendResult,
       }
 
       for (auto *DepJD : JDDepMap[CurJD])
-        if (!Visited.count(DepJD)) {
+        if (Visited.insert(DepJD).second)
           Worklist.push_back(DepJD);
-          Visited.insert(DepJD);
-        }
     }
   });
 

Original file line number	Diff line number	Diff line change
`@@ -521,10 +521,8 @@ void COFFPlatform::pushInitializersLoop(PushInitializersSendResultFn SendResult,`
`521`	`521`	`}`
`522`	`522`
`523`	`523`	`for (auto *DepJD : JDDepMap[CurJD])`
`524`		`- if (!Visited.count(DepJD)) {`
	`524`	`+ if (Visited.insert(DepJD).second)`
`525`	`525`	`Worklist.push_back(DepJD);`
`526`		`- Visited.insert(DepJD);`
`527`		`- }`
`528`	`526`	`}`
`529`	`527`	`});`
`530`	`528`