Skip to content

Commit 4801757

Browse files
committed
Move SystemHeadersCoverage into llvm::coverage in CoverageMappingGen.h
Part of #97952
1 parent 3029378 commit 4801757

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

clang/lib/CodeGen/CodeGenPGO.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ static llvm::cl::opt<bool>
3232
llvm::cl::desc("Enable value profiling"),
3333
llvm::cl::Hidden, llvm::cl::init(false));
3434

35-
extern llvm::cl::opt<bool> SystemHeadersCoverage;
36-
3735
using namespace clang;
3836
using namespace CodeGen;
3937

@@ -1118,7 +1116,7 @@ bool CodeGenPGO::skipRegionMappingForDecl(const Decl *D) {
11181116
// Don't map the functions in system headers.
11191117
const auto &SM = CGM.getContext().getSourceManager();
11201118
auto Loc = D->getBody()->getBeginLoc();
1121-
return !SystemHeadersCoverage && SM.isInSystemHeader(Loc);
1119+
return !llvm::coverage::SystemHeadersCoverage && SM.isInSystemHeader(Loc);
11221120
}
11231121

11241122
void CodeGenPGO::emitCounterRegionMapping(const Decl *D) {

clang/lib/CodeGen/CoverageMappingGen.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,12 @@ static llvm::cl::opt<bool> EmptyLineCommentCoverage(
4646
"disable it on test)"),
4747
llvm::cl::init(true), llvm::cl::Hidden);
4848

49-
llvm::cl::opt<bool> SystemHeadersCoverage(
49+
namespace llvm::coverage {
50+
cl::opt<bool> SystemHeadersCoverage(
5051
"system-headers-coverage",
51-
llvm::cl::desc("Enable collecting coverage from system headers"),
52-
llvm::cl::init(false), llvm::cl::Hidden);
52+
cl::desc("Enable collecting coverage from system headers"), cl::init(false),
53+
cl::Hidden);
54+
}
5355

5456
using namespace clang;
5557
using namespace CodeGen;

clang/lib/CodeGen/CoverageMappingGen.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,13 @@
1919
#include "clang/Lex/Preprocessor.h"
2020
#include "llvm/ADT/DenseMap.h"
2121
#include "llvm/IR/GlobalValue.h"
22+
#include "llvm/Support/CommandLine.h"
2223
#include "llvm/Support/raw_ostream.h"
2324

25+
namespace llvm::coverage {
26+
extern cl::opt<bool> SystemHeadersCoverage;
27+
}
28+
2429
namespace clang {
2530

2631
class LangOptions;

0 commit comments

Comments
 (0)