Skip to content

Commit 4809da8

Browse files
committed
[mlir][NFC] Update Affine operations to use hasVerifier instead of verifier
The verifier field is deprecated, and slated for removal. Differential Revision: https://reviews.llvm.org/D118826
1 parent ef72cf4 commit 4809da8

File tree

2 files changed

+122
-119
lines changed

2 files changed

+122
-119
lines changed

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ class Affine_Op<string mnemonic, list<Trait> traits = []> :
3131
Op<Affine_Dialect, mnemonic, traits> {
3232
// For every affine op, there needs to be a:
3333
// * void print(OpAsmPrinter &p, ${C++ class of Op} op)
34-
// * LogicalResult verify(${C++ class of Op} op)
3534
// * ParseResult parse${C++ class of Op}(OpAsmParser &parser,
3635
// OperationState &result)
3736
// functions.
3837
let printer = [{ return ::print(p, *this); }];
39-
let verifier = [{ return ::verify(*this); }];
4038
let parser = [{ return ::parse$cppClass(parser, result); }];
4139
}
4240

@@ -112,6 +110,7 @@ def AffineApplyOp : Affine_Op<"apply", [NoSideEffect]> {
112110

113111
let hasCanonicalizer = 1;
114112
let hasFolder = 1;
113+
let hasVerifier = 1;
115114
}
116115

117116
def AffineForOp : Affine_Op<"for",
@@ -350,6 +349,7 @@ def AffineForOp : Affine_Op<"for",
350349

351350
let hasCanonicalizer = 1;
352351
let hasFolder = 1;
352+
let hasVerifier = 1;
353353
}
354354

355355
def AffineIfOp : Affine_Op<"if",
@@ -473,6 +473,7 @@ def AffineIfOp : Affine_Op<"if",
473473

474474
let hasCanonicalizer = 1;
475475
let hasFolder = 1;
476+
let hasVerifier = 1;
476477
}
477478

478479
class AffineLoadOpBase<string mnemonic, list<Trait> traits = []> :
@@ -538,6 +539,7 @@ def AffineLoadOp : AffineLoadOpBase<"load"> {
538539

539540
let hasCanonicalizer = 1;
540541
let hasFolder = 1;
542+
let hasVerifier = 1;
541543
}
542544

543545
class AffineMinMaxOpBase<string mnemonic, list<Trait> traits = []> :
@@ -565,11 +567,11 @@ class AffineMinMaxOpBase<string mnemonic, list<Trait> traits = []> :
565567
operands().end()};
566568
}
567569
}];
568-
let verifier = [{ return ::verifyAffineMinMaxOp(*this); }];
569570
let printer = [{ return ::printAffineMinMaxOp(p, *this); }];
570571
let parser = [{ return ::parseAffineMinMaxOp<$cppClass>(parser, result); }];
571572
let hasFolder = 1;
572573
let hasCanonicalizer = 1;
574+
let hasVerifier = 1;
573575
}
574576

575577
def AffineMinOp : AffineMinMaxOpBase<"min", [NoSideEffect]> {
@@ -753,6 +755,7 @@ def AffineParallelOp : Affine_Op<"parallel",
753755
}];
754756

755757
let hasFolder = 1;
758+
let hasVerifier = 1;
756759
}
757760

758761
def AffinePrefetchOp : Affine_Op<"prefetch",
@@ -832,6 +835,7 @@ def AffinePrefetchOp : Affine_Op<"prefetch",
832835

833836
let hasCanonicalizer = 1;
834837
let hasFolder = 1;
838+
let hasVerifier = 1;
835839
}
836840

837841
class AffineStoreOpBase<string mnemonic, list<Trait> traits = []> :
@@ -896,6 +900,7 @@ def AffineStoreOp : AffineStoreOpBase<"store"> {
896900

897901
let hasCanonicalizer = 1;
898902
let hasFolder = 1;
903+
let hasVerifier = 1;
899904
}
900905

901906
def AffineYieldOp : Affine_Op<"yield", [NoSideEffect, Terminator, ReturnLike,
@@ -921,6 +926,7 @@ def AffineYieldOp : Affine_Op<"yield", [NoSideEffect, Terminator, ReturnLike,
921926
];
922927

923928
let assemblyFormat = "attr-dict ($operands^ `:` type($operands))?";
929+
let hasVerifier = 1;
924930
}
925931

926932
def AffineVectorLoadOp : AffineLoadOpBase<"vector_load"> {
@@ -984,6 +990,7 @@ def AffineVectorLoadOp : AffineLoadOpBase<"vector_load"> {
984990
}];
985991

986992
let hasCanonicalizer = 1;
993+
let hasVerifier = 1;
987994
}
988995

989996
def AffineVectorStoreOp : AffineStoreOpBase<"vector_store"> {
@@ -1048,6 +1055,7 @@ def AffineVectorStoreOp : AffineStoreOpBase<"vector_store"> {
10481055
}];
10491056

10501057
let hasCanonicalizer = 1;
1058+
let hasVerifier = 1;
10511059
}
10521060

10531061
#endif // AFFINE_OPS

0 commit comments

Comments
 (0)