Skip to content

Commit 49305ab

Browse files
committed
Address reviewer comments.
1 parent 5806eac commit 49305ab

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

flang/lib/Lower/OpenMP/OpenMP.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2636,8 +2636,9 @@ genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
26362636
mapperNameStr, *varType.declTypeSpec->derivedTypeSpec().GetScope());
26372637
}
26382638

2639-
// Save insert point just after the DeclMapperOp.
2640-
mlir::OpBuilder::InsertPoint insPt = firOpBuilder.saveInsertionPoint();
2639+
// Save current insertion point before moving to the module scope to create
2640+
// the DeclareMapperOp
2641+
mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
26412642

26422643
firOpBuilder.setInsertionPointToStart(converter.getModuleOp().getBody());
26432644
auto mlirType = converter.genType(varType.declTypeSpec->derivedTypeSpec());
@@ -2657,9 +2658,6 @@ genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
26572658
ClauseProcessor cp(converter, semaCtx, clauses);
26582659
cp.processMap(loc, stmtCtx, clauseOps);
26592660
firOpBuilder.create<mlir::omp::DeclareMapperInfoOp>(loc, clauseOps.mapVars);
2660-
2661-
// Restore the insert point to just after the DeclareMapperOp.
2662-
firOpBuilder.restoreInsertionPoint(insPt);
26632661
}
26642662

26652663
static void

0 commit comments

Comments
 (0)