[lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (#102263)

igorkudrin · web-flow · commit 494eec0255d0 · 2024-08-13T10:55:28.000-07:00
There is no need to clone the content and set extraction properties
because `m_auxv` is already in the required form.
diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() {
 }
 
 DataExtractor ProcessElfCore::GetAuxvData() {
-  const uint8_t *start = m_auxv.GetDataStart();
-  size_t len = m_auxv.GetByteSize();
-  lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len));
-  return DataExtractor(buffer, GetByteOrder(), GetAddressByteSize());
+  assert(m_auxv.GetByteSize() == 0 ||
+         (m_auxv.GetByteOrder() == GetByteOrder() &&
+          m_auxv.GetAddressByteSize() == GetAddressByteSize()));
+  return DataExtractor(m_auxv);
 }
 
 bool ProcessElfCore::GetProcessInfo(ProcessInstanceInfo &info) {

Original file line number	Diff line number	Diff line change
`@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() {`
`1077`	`1077`	`}`
`1078`	`1078`
`1079`	`1079`	`DataExtractor ProcessElfCore::GetAuxvData() {`
`1080`		`- const uint8_t *start = m_auxv.GetDataStart();`
`1081`		`- size_t len = m_auxv.GetByteSize();`
`1082`		`- lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len));`
`1083`		`- return DataExtractor(buffer, GetByteOrder(), GetAddressByteSize());`
	`1080`	`+ assert(m_auxv.GetByteSize() == 0 \|\|`
	`1081`	`+ (m_auxv.GetByteOrder() == GetByteOrder() &&`
	`1082`	`+ m_auxv.GetAddressByteSize() == GetAddressByteSize()));`
	`1083`	`+ return DataExtractor(m_auxv);`
`1084`	`1084`	`}`
`1085`	`1085`
`1086`	`1086`	`bool ProcessElfCore::GetProcessInfo(ProcessInstanceInfo &info) {`