Skip to content

Commit 49df87e

Browse files
authored
[libc][printf] Fix out-of-range shift in float320 printf (#144542)
If you enable `LIBC_CONF_PRINTF_FLOAT_TO_STR_USE_FLOAT320` and use a `%f` style printf format directive to print a nonzero number too small to show up in the output digits, e.g. `printf("%.2f", 0.001)`, then the output would be intermittently incorrect, because `DyadicFloat::as_mantissa_type_rounded` would try to shift the 320-bit mantissa right by more than 320 bits, invoking the 'undefined behavior' clause commented in the `shift()` function in `big_int.h`. There were already tests in the libc test suite exercising this case, e.g. the subnormal tests in `LlvmLibcSPrintfTest.FloatDecimalConv` use `%f` at the default precision of 6 decimal places on tiny numbers such as 2^-1027. But because the behavior is undefined, they don't visibly fail all the time, and in all previous test runs we'd tried with USE_FLOAT320, they had got lucky. The fix is simply to detect an out-of-range right shift before doing it, and instead just set the output value to zero.
1 parent a38932a commit 49df87e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

libc/src/__support/FPUtil/dyadic_float.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,10 @@ template <size_t Bits> struct DyadicFloat {
465465
// exponents coming in to this function _shouldn't_ be that large). The
466466
// result should always end up as a positive size_t.
467467
size_t shift = -static_cast<size_t>(exponent);
468-
new_mant >>= shift;
468+
if (shift >= Bits)
469+
new_mant = 0;
470+
else
471+
new_mant >>= shift;
469472
round_dir = rounding_direction(mantissa, shift, sign);
470473
if (round_dir > 0)
471474
++new_mant;

0 commit comments

Comments
 (0)