Skip to content

Commit 4aeb2f1

Browse files
[CI] Remove Duplicate Heartbeat in Metrics Script
This patch removes an extra heartbeat metric in the metrics python file. Before it was performed twice, once in the main function, and once in the get_sampled_workflow_metrics function. We only need one to keep everything happy, and I've chosen to keep the one in get_sampled_workflow_metrics as it seems a more appropriate place to keep it. Reviewers: Keenuts, lnihlen Reviewed By: lnihlen Pull Request: #127275
1 parent 2d878cc commit 4aeb2f1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

.ci/metrics/metrics.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,10 +270,6 @@ def main():
270270
while True:
271271
current_metrics = get_per_workflow_metrics(github_repo, workflows_to_track)
272272
current_metrics += get_sampled_workflow_metrics(github_repo)
273-
# Always send a hearbeat metric so we can monitor is this container is still able to log to Grafana.
274-
current_metrics.append(
275-
GaugeMetric("metrics_container_heartbeat", 1, time.time_ns())
276-
)
277273

278274
upload_metrics(current_metrics, grafana_metrics_userid, grafana_api_key)
279275
print(f"Uploaded {len(current_metrics)} metrics", file=sys.stderr)

0 commit comments

Comments
 (0)