Skip to content

Commit 4b676e1

Browse files
[TableGen] Avoid repeated hash lookups (NFC) (#107669)
1 parent 11eae67 commit 4b676e1

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1696,9 +1696,8 @@ bool CombineRuleBuilder::emitPatFragMatchPattern(
16961696
DenseSet<const Pattern *> &SeenPats) {
16971697
auto StackTrace = PrettyStackTraceEmit(RuleDef, &PFP);
16981698

1699-
if (SeenPats.contains(&PFP))
1699+
if (!SeenPats.insert(&PFP).second)
17001700
return true;
1701-
SeenPats.insert(&PFP);
17021701

17031702
const auto &PF = PFP.getPatFrag();
17041703

@@ -1919,11 +1918,9 @@ bool CombineRuleBuilder::emitInstructionApplyPattern(
19191918
StringMap<unsigned> &OperandToTempRegID) {
19201919
auto StackTrace = PrettyStackTraceEmit(RuleDef, &P);
19211920

1922-
if (SeenPats.contains(&P))
1921+
if (!SeenPats.insert(&P).second)
19231922
return true;
19241923

1925-
SeenPats.insert(&P);
1926-
19271924
// First, render the uses.
19281925
for (auto &Op : P.named_operands()) {
19291926
if (Op.isDef())
@@ -2188,11 +2185,9 @@ bool CombineRuleBuilder::emitCodeGenInstructionMatchPattern(
21882185
OperandMapperFnRef OperandMapper) {
21892186
auto StackTrace = PrettyStackTraceEmit(RuleDef, &P);
21902187

2191-
if (SeenPats.contains(&P))
2188+
if (!SeenPats.insert(&P).second)
21922189
return true;
21932190

2194-
SeenPats.insert(&P);
2195-
21962191
IM.addPredicate<InstructionOpcodeMatcher>(&P.getInst());
21972192
declareInstExpansion(CE, IM, P.getName());
21982193

0 commit comments

Comments
 (0)