Skip to content

Commit 4bcea4e

Browse files
[mlir] Fix unused-variable warnings
This patch fixes warnings of the form: mlir/lib/Conversion/VectorToGPU/VectorToGPU.cpp:320:19: error: unused variable 'result' [-Werror,-Wunused-variable]
1 parent 9e306ad commit 4bcea4e

File tree

9 files changed

+12
-0
lines changed

9 files changed

+12
-0
lines changed

mlir/include/mlir/Query/Matcher/SliceMatchers.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ bool BackwardSliceMatcher<Matcher>::matches(
114114
};
115115
LogicalResult result = getBackwardSlice(rootOp, &backwardSlice, options);
116116
assert(result.succeeded() && "expected backward slice to succeed");
117+
(void)result;
117118
return options.inclusive ? backwardSlice.size() > 1
118119
: backwardSlice.size() >= 1;
119120
}

mlir/lib/Analysis/SliceAnalysis.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ mlir::getSlice(Operation *op, const BackwardSliceOptions &backwardSliceOptions,
180180
LogicalResult result =
181181
getBackwardSlice(currentOp, &backwardSlice, backwardSliceOptions);
182182
assert(result.succeeded());
183+
(void)result;
183184
slice.insert_range(backwardSlice);
184185

185186
// Compute and insert the forwardSlice starting from currentOp.
@@ -204,6 +205,7 @@ static bool dependsOnCarriedVals(Value value,
204205
};
205206
LogicalResult result = getBackwardSlice(value, &slice, sliceOptions);
206207
assert(result.succeeded());
208+
(void)result;
207209

208210
// Check that none of the operands of the operations in the backward slice are
209211
// loop iteration arguments, and neither is the value itself.

mlir/lib/Conversion/VectorToGPU/VectorToGPU.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ getSliceContract(Operation *op,
320320
LogicalResult result =
321321
getBackwardSlice(currentOp, &backwardSlice, backwardSliceOptions);
322322
assert(result.succeeded() && "expected a backward slice");
323+
(void)result;
323324
slice.insert_range(backwardSlice);
324325

325326
// Compute and insert the forwardSlice starting from currentOp.

mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,13 @@ static void computeBackwardSlice(tensor::PadOp padOp,
126126
for (Value v : valuesDefinedAbove) {
127127
LogicalResult result = getBackwardSlice(v, &backwardSlice, sliceOptions);
128128
assert(result.succeeded() && "expected a backward slice");
129+
(void)result;
129130
}
130131
// Then, add the backward slice from padOp itself.
131132
LogicalResult result =
132133
getBackwardSlice(padOp.getOperation(), &backwardSlice, sliceOptions);
133134
assert(result.succeeded() && "expected a backward slice");
135+
(void)result;
134136
}
135137

136138
//===----------------------------------------------------------------------===//

mlir/lib/Dialect/NVGPU/TransformOps/NVGPUTransformOps.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ static void getPipelineStages(
293293
if (stage0Ops.contains(&op)) {
294294
LogicalResult result = getBackwardSlice(&op, &dependencies, options);
295295
assert(result.succeeded() && "expected a backward slice");
296+
(void)result;
296297
}
297298
}
298299

mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1774,6 +1774,7 @@ checkAssumptionForLoop(Operation *loopOp, Operation *consumerOp,
17741774
for (auto operand : consumerOp->getOperands()) {
17751775
LogicalResult result = getBackwardSlice(operand, &slice, options);
17761776
assert(result.succeeded() && "expected a backward slice");
1777+
(void)result;
17771778
}
17781779

17791780
if (!slice.empty()) {

mlir/lib/Transforms/Utils/RegionUtils.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,6 +1096,7 @@ LogicalResult mlir::moveOperationDependencies(RewriterBase &rewriter,
10961096
llvm::SetVector<Operation *> slice;
10971097
LogicalResult result = getBackwardSlice(op, &slice, options);
10981098
assert(result.succeeded() && "expected a backward slice");
1099+
(void)result;
10991100

11001101
// If the slice contains `insertionPoint` cannot move the dependencies.
11011102
if (slice.contains(insertionPoint)) {
@@ -1162,6 +1163,7 @@ LogicalResult mlir::moveValueDefinitions(RewriterBase &rewriter,
11621163
for (auto value : prunedValues) {
11631164
LogicalResult result = getBackwardSlice(value, &slice, options);
11641165
assert(result.succeeded() && "expected a backward slice");
1166+
(void)result;
11651167
}
11661168

11671169
// If the slice contains `insertionPoint` cannot move the dependencies.

mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ void VectorizerTestPass::testBackwardSlicing(llvm::raw_ostream &outs) {
157157
LogicalResult result =
158158
getBackwardSlice(m.getMatchedOperation(), &backwardSlice);
159159
assert(result.succeeded() && "expected a backward slice");
160+
(void)result;
160161
outs << "\nmatched: " << *m.getMatchedOperation()
161162
<< " backward static slice: ";
162163
for (auto *op : backwardSlice)

mlir/test/lib/IR/TestSlicing.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ static LogicalResult createBackwardSliceFunction(Operation *op,
4343
options.omitUsesFromAbove = false;
4444
LogicalResult result = getBackwardSlice(op, &slice, options);
4545
assert(result.succeeded() && "expected a backward slice");
46+
(void)result;
4647
for (Operation *slicedOp : slice)
4748
builder.clone(*slicedOp, mapper);
4849
builder.create<func::ReturnOp>(loc);

0 commit comments

Comments
 (0)