Skip to content

Commit 4c9696a

Browse files
committed
revert some setZero
1 parent 1f7034c commit 4c9696a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

llvm/lib/Support/KnownBits.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,8 @@ KnownBits KnownBits::lshr(const KnownBits &LHS, const KnownBits &RHS,
391391
if (Exact) {
392392
unsigned FirstOne = LHS.countMaxTrailingZeros();
393393
if (FirstOne < MinShiftAmount) {
394-
// Always poison.
394+
// Always poison. Return zero because we don't like returning conflict.
395+
Known.setAllZero();
395396
return Known;
396397
}
397398
MaxShiftAmount = std::min(MaxShiftAmount, FirstOne);
@@ -980,7 +981,8 @@ KnownBits KnownBits::udiv(const KnownBits &LHS, const KnownBits &RHS,
980981
KnownBits Known(BitWidth);
981982

982983
if (LHS.isZero() || RHS.isZero()) {
983-
// Result is either known Zero or UB.
984+
// Result is either known Zero or UB. Return Zero either way.
985+
Known.setAllZero();
984986
return Known;
985987
}
986988

0 commit comments

Comments
 (0)