Fixup! address review comments

felipepiovezan · felipepiovezan · commit 4f874c829643 · 2024-09-04T07:02:16.000-07:00
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -1638,7 +1638,7 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo(
           for (llvm::StringRef entry : llvm::split(value, ',')) {
             if (entry == "stack")
               region_info.SetIsStackMemory(MemoryRegionInfo::eYes);
-            if (entry == "heap")
+            else if (entry == "heap")
               region_info.SetIsStackMemory(MemoryRegionInfo::eNo);
           }
         } else if (name == "error") {

Original file line number	Diff line number	Diff line change
`@@ -1638,7 +1638,7 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo(`
`1638`	`1638`	`for (llvm::StringRef entry : llvm::split(value, ',')) {`
`1639`	`1639`	`if (entry == "stack")`
`1640`	`1640`	`region_info.SetIsStackMemory(MemoryRegionInfo::eYes);`
`1641`		`- if (entry == "heap")`
	`1641`	`+ else if (entry == "heap")`
`1642`	`1642`	`region_info.SetIsStackMemory(MemoryRegionInfo::eNo);`
`1643`	`1643`	`}`
`1644`	`1644`	`} else if (name == "error") {`