Skip to content

Commit 512193b

Browse files
committed
[AArch64][SVE2] Use rshrnb for masked stores
This patch is a follow up on https://reviews.llvm.org/D155299. This patch combines add+lsr to rshrnb when 'B' in: C = A + B D = C >> Shift is equal to (1 << (Shift-1), and the bits in the top half of each vector element are zeroed or ignored, such as in a truncating masked store.
1 parent febf5c9 commit 512193b

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21017,6 +21017,21 @@ static SDValue performMSTORECombine(SDNode *N,
2101721017
}
2101821018
}
2101921019

21020+
if (MST->isTruncatingStore()) {
21021+
if (SDValue Rshrnb = trySimplifySrlAddToRshrnb(Value, DAG, Subtarget)) {
21022+
EVT ValueVT = Value->getValueType(0);
21023+
EVT MemVT = MST->getMemoryVT();
21024+
if ((ValueVT == MVT::nxv8i16 && MemVT == MVT::nxv8i8) ||
21025+
(ValueVT == MVT::nxv4i32 && MemVT == MVT::nxv4i16) ||
21026+
(ValueVT == MVT::nxv2i64 && MemVT == MVT::nxv2i32)) {
21027+
return DAG.getMaskedStore(
21028+
MST->getChain(), DL, Rshrnb, MST->getBasePtr(), MST->getOffset(),
21029+
MST->getMask(), MST->getMemoryVT(), MST->getMemOperand(),
21030+
MST->getAddressingMode(), true);
21031+
}
21032+
}
21033+
}
21034+
2102021035
return SDValue();
2102121036
}
2102221037

llvm/test/CodeGen/AArch64/sve2-intrinsics-combine-rshrnb.ll

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,3 +298,22 @@ define void @neg_add_lshr_rshrnb_s(ptr %ptr, ptr %dst, i64 %index){
298298
store <vscale x 2 x i16> %3, ptr %4, align 1
299299
ret void
300300
}
301+
302+
define void @masked_store_rshrnb(ptr %ptr, ptr %dst, i64 %index, <vscale x 8 x i1> %mask) { ; preds = %vector.body, %vector.ph
303+
; CHECK-LABEL: masked_store_rshrnb:
304+
; CHECK: // %bb.0:
305+
; CHECK-NEXT: ld1h { z0.h }, p0/z, [x0]
306+
; CHECK-NEXT: rshrnb z0.b, z0.h, #6
307+
; CHECK-NEXT: st1b { z0.h }, p0, [x1, x2]
308+
; CHECK-NEXT: ret
309+
%wide.masked.load = tail call <vscale x 8 x i16> @llvm.masked.load.nxv8i16.p0(ptr %ptr, i32 2, <vscale x 8 x i1> %mask, <vscale x 8 x i16> poison)
310+
%1 = add <vscale x 8 x i16> %wide.masked.load, trunc (<vscale x 8 x i32> shufflevector (<vscale x 8 x i32> insertelement (<vscale x 8 x i32> poison, i32 32, i64 0), <vscale x 8 x i32> poison, <vscale x 8 x i32> zeroinitializer) to <vscale x 8 x i16>)
311+
%2 = lshr <vscale x 8 x i16> %1, trunc (<vscale x 8 x i32> shufflevector (<vscale x 8 x i32> insertelement (<vscale x 8 x i32> poison, i32 6, i64 0), <vscale x 8 x i32> poison, <vscale x 8 x i32> zeroinitializer) to <vscale x 8 x i16>)
312+
%3 = trunc <vscale x 8 x i16> %2 to <vscale x 8 x i8>
313+
%4 = getelementptr inbounds i8, ptr %dst, i64 %index
314+
tail call void @llvm.masked.store.nxv8i8.p0(<vscale x 8 x i8> %3, ptr %4, i32 1, <vscale x 8 x i1> %mask)
315+
ret void
316+
}
317+
318+
declare void @llvm.masked.store.nxv8i8.p0(<vscale x 8 x i8>, ptr, i32, <vscale x 8 x i1>)
319+
declare <vscale x 8 x i16> @llvm.masked.load.nxv8i16.p0(ptr, i32, <vscale x 8 x i1>, <vscale x 8 x i16>)

0 commit comments

Comments
 (0)