Skip to content

Commit 517728f

Browse files
committed
[SelectionDAG] Use DAG.getNOT to further simplify some code. NFC
Followup to D109483
1 parent 584a5d1 commit 517728f

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3240,8 +3240,7 @@ bool SelectionDAGLegalize::ExpandNode(SDNode *Node) {
32403240
assert(TLI.isOperationLegalOrCustom(ISD::ADD, VT) &&
32413241
TLI.isOperationLegalOrCustom(ISD::XOR, VT) &&
32423242
"Don't know how to expand this subtraction!");
3243-
Tmp1 = DAG.getNode(ISD::XOR, dl, VT, Node->getOperand(1),
3244-
DAG.getAllOnesConstant(dl, VT));
3243+
Tmp1 = DAG.getNOT(dl, Node->getOperand(1), VT);
32453244
Tmp1 = DAG.getNode(ISD::ADD, dl, VT, Tmp1, DAG.getConstant(1, dl, VT));
32463245
Results.push_back(DAG.getNode(ISD::ADD, dl, VT, Node->getOperand(0), Tmp1));
32473246
break;

llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -958,8 +958,7 @@ SDValue VectorLegalizer::ExpandSELECT(SDNode *Node) {
958958
Op1 = DAG.getNode(ISD::BITCAST, DL, MaskTy, Op1);
959959
Op2 = DAG.getNode(ISD::BITCAST, DL, MaskTy, Op2);
960960

961-
SDValue AllOnes = DAG.getAllOnesConstant(DL, MaskTy);
962-
SDValue NotMask = DAG.getNode(ISD::XOR, DL, MaskTy, Mask, AllOnes);
961+
SDValue NotMask = DAG.getNOT(DL, Mask, MaskTy);
963962

964963
Op1 = DAG.getNode(ISD::AND, DL, MaskTy, Op1, Mask);
965964
Op2 = DAG.getNode(ISD::AND, DL, MaskTy, Op2, NotMask);
@@ -1204,8 +1203,7 @@ SDValue VectorLegalizer::ExpandVSELECT(SDNode *Node) {
12041203
Op1 = DAG.getNode(ISD::BITCAST, DL, VT, Op1);
12051204
Op2 = DAG.getNode(ISD::BITCAST, DL, VT, Op2);
12061205

1207-
SDValue AllOnes = DAG.getAllOnesConstant(DL, VT);
1208-
SDValue NotMask = DAG.getNode(ISD::XOR, DL, VT, Mask, AllOnes);
1206+
SDValue NotMask = DAG.getNOT(DL, Mask, VT);
12091207

12101208
Op1 = DAG.getNode(ISD::AND, DL, VT, Op1, Mask);
12111209
Op2 = DAG.getNode(ISD::AND, DL, VT, Op2, NotMask);

0 commit comments

Comments
 (0)