Skip to content

Commit 51d70a0

Browse files
committed
Point to tracking issue for fp precision in spirv conversions
1 parent f0d6c86 commit 51d70a0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,9 +503,10 @@ static std::optional<Value> createGroupReduceOp(OpBuilder &builder,
503503
return std::nullopt;
504504
}
505505

506-
// TODO: The SPIR-V spec does not specify how -0.0 / +0.0 and NaN values are
507-
// handled in *FMin/*FMax reduction ops. We should double account for this not
508-
// being defined in this conversion.
506+
// TODO(https://github.com/llvm/llvm-project/issues/73459): The SPIR-V spec
507+
// does not specify how -0.0 / +0.0 and NaN values are handled in *FMin/*FMax
508+
// reduction ops. We should account possible precision requirements in this
509+
// conversion.
509510

510511
using ReduceType = gpu::AllReduceOperation;
511512
const OpHandler handlers[] = {

0 commit comments

Comments
 (0)