Skip to content

Commit 528150b

Browse files
authored
[hwasan] Separate sections in report (#76130)
It makes them easier to read.
1 parent 1830fad commit 528150b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

compiler-rt/lib/hwasan/hwasan_report.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa,
233233
if (obj_offset >= local.size)
234234
continue;
235235
if (!found_local) {
236-
Printf("Potentially referenced stack objects:\n");
236+
Printf("\nPotentially referenced stack objects:\n");
237237
found_local = true;
238238
}
239239
Printf(" %s in %s %s:%d\n", local.name, local.function_name,
@@ -363,7 +363,7 @@ static void PrintTagsAroundAddr(uptr addr, GetTag get_tag,
363363
InternalScopedString s;
364364
addr = MemToShadow(addr);
365365
s.AppendF(
366-
"Memory tags around the buggy address (one tag corresponds to %zd "
366+
"\nMemory tags around the buggy address (one tag corresponds to %zd "
367367
"bytes):\n",
368368
kShadowAlignment);
369369
PrintTagInfoAroundAddr(addr, kShadowLines, s,
@@ -803,8 +803,10 @@ void BaseReport::PrintAddressDescription() const {
803803
}
804804

805805
// Print the remaining threads, as an extra information, 1 line per thread.
806-
if (flags()->print_live_threads_info)
806+
if (flags()->print_live_threads_info) {
807+
Printf("\n");
807808
hwasanThreadList().VisitAllLiveThreads([&](Thread *t) { t->Announce(); });
809+
}
808810

809811
if (!num_descriptions_printed)
810812
// We exhausted our possibilities. Bail out.
@@ -1020,7 +1022,7 @@ void ReportTagMismatch(StackTrace *stack, uptr tagged_addr, uptr access_size,
10201022
// See the frame breakdown defined in __hwasan_tag_mismatch (from
10211023
// hwasan_tag_mismatch_{aarch64,riscv64}.S).
10221024
void ReportRegisters(const uptr *frame, uptr pc) {
1023-
Printf("Registers where the failure occurred (pc %p):\n", pc);
1025+
Printf("\nRegisters where the failure occurred (pc %p):\n", pc);
10241026

10251027
// We explicitly print a single line (4 registers/line) each iteration to
10261028
// reduce the amount of logcat error messages printed. Each Printf() will

0 commit comments

Comments
 (0)