Skip to content

Commit 53333c8

Browse files
committed
Revert "[clang][diagnostics] Add -Wpacked-non-pod to -Wall"
This reverts commit 9ed3d85. It broke some bots: https://lab.llvm.org/buildbot/#/builders/245/builds/8876
1 parent 68c5d46 commit 53333c8

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,6 @@ Improvements to Clang's diagnostics
307307
(`#62850: <https://github.com/llvm/llvm-project/issues/62850>`_).
308308
- Clang now warns when any predefined macro is undefined or redefined, instead
309309
of only some of them.
310-
- ``-Wpacked-non-pod`` is now included in ``-Wall``.
311-
(`#60832: <https://github.com/llvm/llvm-project/issues/60832>`_)
312310

313311
Bug Fixes in This Version
314312
-------------------------

clang/include/clang/Basic/DiagnosticGroups.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ def Consumed : DiagGroup<"consumed">;
10601060
// warning should be active _only_ when -Wall is passed in, mark it as
10611061
// DefaultIgnore in addition to putting it here.
10621062
def All : DiagGroup<"all", [Most, Parentheses, Switch, SwitchBool,
1063-
MisleadingIndentation, PackedNonPod]>;
1063+
MisleadingIndentation]>;
10641064

10651065
// Warnings that should be in clang-cl /w4.
10661066
def : DiagGroup<"CL4", [All, Extra]>;

clang/test/CodeGenCXX/warn-all-padded-packed-packed-non-pod.cpp renamed to clang/test/CodeGenCXX/warn-padded-packed.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
1-
// RUN: %clang_cc1 -Wpadded -Wpacked -verify=expected,top %s -emit-llvm-only
2-
// RUN: %clang_cc1 -Wpadded -Wpacked -verify=expected,abi15 -fclang-abi-compat=15 %s -emit-llvm-only
3-
// -Wpacked-non-pod itself should not emit the "packed attribute is unnecessary" warnings.
4-
// RUN: %clang_cc1 -Wpacked-non-pod -verify=top %s -emit-llvm-only
5-
// -Wall should not emit the "packed attribute is unnecessary" warnings without -Wpacked.
6-
// RUN: %clang_cc1 -Wall -verify=top %s -emit-llvm-only
7-
1+
// RUN: %clang_cc1 -triple=x86_64-none-none -Wpadded -Wpacked -verify=expected,top %s -emit-llvm-only
2+
// RUN: %clang_cc1 -triple=x86_64-none-none -Wpadded -Wpacked -verify=expected,abi15 -fclang-abi-compat=15 %s -emit-llvm-only
83

94
struct S1 {
105
char c;

clang/test/Misc/warning-wall.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ CHECK-NEXT: -Wdangling-else
9999
CHECK-NEXT: -Wswitch
100100
CHECK-NEXT: -Wswitch-bool
101101
CHECK-NEXT: -Wmisleading-indentation
102-
CHECK-NEXT: -Wpacked-non-pod
103102

104103

105104
CHECK-NOT:-W

0 commit comments

Comments
 (0)