LAA: add missed swap when inverting src, sink (NFC)

artagnon · artagnon · commit 54341565af1b · 2025-01-09T11:13:45.000Z
We miss swapping the types of the source and sink when the source and
sink are inverted, leaving a footgun behind. Fix this.
diff --git a/llvm/lib/Analysis/LoopAccessAnalysis.cpp b/llvm/lib/Analysis/LoopAccessAnalysis.cpp
@@ -1921,6 +1921,7 @@ MemoryDepChecker::getDependenceDistanceStrideAndSize(
   if (StrideAPtr && *StrideAPtr < 0) {
     std::swap(Src, Sink);
     std::swap(AInst, BInst);
+    std::swap(ATy, BTy);
     std::swap(StrideAPtr, StrideBPtr);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1921,6 +1921,7 @@ MemoryDepChecker::getDependenceDistanceStrideAndSize(`
`1921`	`1921`	`if (StrideAPtr && *StrideAPtr < 0) {`
`1922`	`1922`	`std::swap(Src, Sink);`
`1923`	`1923`	`std::swap(AInst, BInst);`
	`1924`	`+ std::swap(ATy, BTy);`
`1924`	`1925`	`std::swap(StrideAPtr, StrideBPtr);`
`1925`	`1926`	`}`
`1926`	`1927`