Skip to content

Commit 54878b8

Browse files
[libc] remove fragile test from mincore (#74026)
1 parent 5c60e2c commit 54878b8

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

libc/test/src/sys/mman/linux/mincore_test.cpp

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,13 @@ static char *aligned_addr(void *addr, size_t alignment) {
4141

4242
TEST(LlvmLibcMincoreTest, InvalidVec) {
4343
size_t page_size = static_cast<size_t>(LIBC_NAMESPACE::sysconf(_SC_PAGESIZE));
44-
void *addr = LIBC_NAMESPACE::mmap(nullptr, 5 * page_size, PROT_READ,
44+
void *addr = LIBC_NAMESPACE::mmap(nullptr, page_size, PROT_READ,
4545
MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
4646
EXPECT_NE(addr, MAP_FAILED);
47-
// Since we allocated 5 pages, we can find an aligned boundary after which
48-
// there are at least 4 pages
4947
char *aligned = aligned_addr(addr, page_size);
50-
libc_errno = 0;
5148
int res = LIBC_NAMESPACE::mincore(aligned, 1, nullptr);
5249
EXPECT_THAT(res, Fails(EFAULT, -1));
53-
void *area = LIBC_NAMESPACE::mmap(nullptr, page_size, PROT_READ | PROT_WRITE,
54-
MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
55-
EXPECT_NE(area, MAP_FAILED);
56-
unsigned char *ptr = static_cast<unsigned char *>(area) + page_size - 3;
57-
res = LIBC_NAMESPACE::mincore(aligned, 4 * page_size, ptr);
58-
EXPECT_THAT(res, Fails(EFAULT, -1));
59-
EXPECT_THAT(LIBC_NAMESPACE::munmap(addr, 5 * page_size), Succeeds());
60-
EXPECT_THAT(LIBC_NAMESPACE::munmap(area, page_size), Succeeds());
50+
EXPECT_THAT(LIBC_NAMESPACE::munmap(addr, page_size), Succeeds());
6151
}
6252

6353
TEST(LlvmLibcMincoreTest, UnalignedAddr) {

0 commit comments

Comments
 (0)