Skip to content

Commit 5528784

Browse files
committed
[ORC][examples] Fix off-by-one error when handling null terminators.
LLVMCreateMemoryBufferWithMemoryRange checks for a null terminator after the given range, so we need to pass the length of the module string (excluding the null terminator).
1 parent 7581f13 commit 5528784

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

llvm/examples/OrcV2Examples/OrcV2CBindingsLazy/OrcV2CBindingsLazy.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ int main(int argc, char *argv[]) {
127127
LLVMErrorRef Err;
128128

129129
LLVMOrcThreadSafeModuleRef FooTSM;
130-
if ((Err =
131-
parseExampleModule(FooMod, sizeof(FooMod), "foo-mod", &FooTSM))) {
130+
if ((Err = parseExampleModule(FooMod, sizeof(FooMod) - 1, "foo-mod",
131+
&FooTSM))) {
132132
MainResult = handleError(Err);
133133
goto jit_cleanup;
134134
}
@@ -142,8 +142,8 @@ int main(int argc, char *argv[]) {
142142
}
143143

144144
LLVMOrcThreadSafeModuleRef BarTSM;
145-
if ((Err =
146-
parseExampleModule(BarMod, sizeof(BarMod), "bar-mod", &BarTSM))) {
145+
if ((Err = parseExampleModule(BarMod, sizeof(BarMod) - 1, "bar-mod",
146+
&BarTSM))) {
147147
MainResult = handleError(Err);
148148
goto jit_cleanup;
149149
}
@@ -155,7 +155,7 @@ int main(int argc, char *argv[]) {
155155
}
156156

157157
LLVMOrcThreadSafeModuleRef MainTSM;
158-
if ((Err = parseExampleModule(MainMod, sizeof(MainMod), "main-mod",
158+
if ((Err = parseExampleModule(MainMod, sizeof(MainMod) - 1, "main-mod",
159159
&MainTSM))) {
160160
MainResult = handleError(Err);
161161
goto jit_cleanup;

0 commit comments

Comments
 (0)