Skip to content

Commit 555a71b

Browse files
[LLDB] Don't forcefully initialize the process trace plugin (#71455)
This was causing some process to wrongfully be handled by ProcessTrace. The only place this was being used is in the intel pt plugin, but it doesn't even build anymore, so I'm sure no one is using it.
1 parent 3c356ee commit 555a71b

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

lldb/source/API/SystemInitializerFull.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ llvm::Error SystemInitializerFull::Initialize() {
6868
#define LLDB_PLUGIN(p) LLDB_PLUGIN_INITIALIZE(p);
6969
#include "Plugins/Plugins.def"
7070

71-
// Initialize plug-ins in core LLDB
72-
ProcessTrace::Initialize();
73-
7471
// Scan for any system or user LLDB plug-ins
7572
PluginManager::Initialize();
7673

lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,11 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t pid,
103103
ParsedProcess parsed_process;
104104
parsed_process.target_sp = target_sp;
105105

106-
ProcessSP process_sp = target_sp->CreateProcess(
107-
/*listener*/ nullptr, "trace",
108-
/*crash_file*/ nullptr,
109-
/*can_connect*/ false);
106+
// This should instead try to directly create an instance of ProcessTrace.
107+
// ProcessSP process_sp = target_sp->CreateProcess(
108+
// /*listener*/ nullptr, "trace",
109+
// /*crash_file*/ nullptr,
110+
// /*can_connect*/ false);
110111

111112
process_sp->SetID(static_cast<lldb::pid_t>(pid));
112113

0 commit comments

Comments
 (0)