Skip to content

Commit 55c181a

Browse files
committed
Revert "[AArch64][GlobalISel] Optimize conjunctions of compares to conditional compares."
This reverts commit 2a46450. This triggers the following assertion in an internal project: Assertion failed: (VRegInfo[Reg.id()].first.is<const TargetRegisterClass *>() && "Register class not set, wrong accessor"), function getRegClass, file MachineRegisterInfo.h, line 646. I'll work with the author directly to get a reproducer.
1 parent 359a792 commit 55c181a

File tree

3 files changed

+194
-479
lines changed

3 files changed

+194
-479
lines changed

llvm/include/llvm/CodeGen/GlobalISel/GenericMachineInstrs.h

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#ifndef LLVM_CODEGEN_GLOBALISEL_GENERICMACHINEINSTRS_H
1515
#define LLVM_CODEGEN_GLOBALISEL_GENERICMACHINEINSTRS_H
1616

17-
#include "llvm/IR/Instructions.h"
1817
#include "llvm/CodeGen/MachineInstr.h"
1918
#include "llvm/CodeGen/MachineMemOperand.h"
2019
#include "llvm/CodeGen/TargetOpcodes.h"
@@ -227,37 +226,6 @@ class GSelect : public GenericMachineInstr {
227226
}
228227
};
229228

230-
/// Represent a G_ICMP or G_FCMP.
231-
class GAnyCmp : public GenericMachineInstr {
232-
public:
233-
CmpInst::Predicate getCond() const {
234-
return static_cast<CmpInst::Predicate>(getOperand(1).getPredicate());
235-
}
236-
Register getLHSReg() const { return getReg(2); }
237-
Register getRHSReg() const { return getReg(3); }
238-
239-
static bool classof(const MachineInstr *MI) {
240-
return MI->getOpcode() == TargetOpcode::G_ICMP ||
241-
MI->getOpcode() == TargetOpcode::G_FCMP;
242-
}
243-
};
244-
245-
/// Represent a G_ICMP.
246-
class GICmp : public GAnyCmp {
247-
public:
248-
static bool classof(const MachineInstr *MI) {
249-
return MI->getOpcode() == TargetOpcode::G_ICMP;
250-
}
251-
};
252-
253-
/// Represent a G_FCMP.
254-
class GFCmp : public GAnyCmp {
255-
public:
256-
static bool classof(const MachineInstr *MI) {
257-
return MI->getOpcode() == TargetOpcode::G_FCMP;
258-
}
259-
};
260-
261229
} // namespace llvm
262230

263231
#endif // LLVM_CODEGEN_GLOBALISEL_GENERICMACHINEINSTRS_H

0 commit comments

Comments
 (0)