Skip to content

Commit 563d5e0

Browse files
committed
Remove redundant test for thumb
1 parent 38c2c66 commit 563d5e0

File tree

1 file changed

+4
-29
lines changed

1 file changed

+4
-29
lines changed

llvm/unittests/ExecutionEngine/JITLink/AArch32ErrorTests.cpp

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ TEST(AArch32_ELF, readAddendArmErrors) {
4949
Edge InvalidEdge(Edge::GenericEdgeKind::Invalid, 0 /*Offset*/, TargetSymbol,
5050
0 /*Addend*/);
5151

52+
// Edge kind is tested, block itself is not significant here. So it is tested
53+
// once in Arm
5254
EXPECT_THAT_EXPECTED(readAddendData(*G, BArm, InvalidEdge),
5355
FailedWithMessage(testing::HasSubstr(
5456
"can not read implicit addend for aarch32 edge kind "
@@ -93,21 +95,6 @@ TEST(AArch32_ELF, readAddendThumbErrors) {
9395
Edge InvalidEdge(Edge::GenericEdgeKind::Invalid, 0 /*Offset*/, TargetSymbol,
9496
0 /*Addend*/);
9597

96-
EXPECT_THAT_EXPECTED(readAddendData(*G, BThumb, InvalidEdge),
97-
FailedWithMessage(testing::HasSubstr(
98-
"can not read implicit addend for aarch32 edge kind "
99-
"INVALID RELOCATION")));
100-
101-
EXPECT_THAT_EXPECTED(readAddendArm(*G, BThumb, InvalidEdge),
102-
FailedWithMessage(testing::HasSubstr(
103-
"can not read implicit addend for aarch32 edge kind "
104-
"INVALID RELOCATION")));
105-
106-
EXPECT_THAT_EXPECTED(readAddendThumb(*G, BThumb, InvalidEdge, ArmCfg),
107-
FailedWithMessage(testing::HasSubstr(
108-
"can not read implicit addend for aarch32 edge kind "
109-
"INVALID RELOCATION")));
110-
11198
for (Edge::Kind K = FirstThumbRelocation; K < LastThumbRelocation; K += 1) {
11299
Edge E(K, 0, TargetSymbol, 0);
113100
EXPECT_THAT_EXPECTED(
@@ -132,6 +119,8 @@ TEST(AArch32_ELF, applyFixupArmErrors) {
132119
Edge InvalidEdge(Edge::GenericEdgeKind::Invalid, 0 /*Offset*/, TargetSymbol,
133120
0 /*Addend*/);
134121

122+
// Edge kind is tested, block itself is not significant here. So it is tested
123+
// once in Arm
135124
EXPECT_THAT_ERROR(
136125
applyFixupData(*G, BArm, InvalidEdge),
137126
FailedWithMessage(testing::HasSubstr(
@@ -181,25 +170,11 @@ TEST(AArch32_ELF, applyFixupThumbErrors) {
181170

182171
auto &BThumb = G->createMutableContentBlock(
183172
Sec, MutableThumbContent, B4DummyAddr, ThumbAlignment, AlignmentOffset);
184-
185173
Symbol &TargetSymbol =
186174
G->addAnonymousSymbol(BThumb, SymbolOffset, SymbolSize, false, false);
187175
Edge InvalidEdge(Edge::GenericEdgeKind::Invalid, 0 /*Offset*/, TargetSymbol,
188176
0 /*Addend*/);
189177

190-
EXPECT_THAT_ERROR(
191-
applyFixupData(*G, BThumb, InvalidEdge),
192-
FailedWithMessage(testing::HasSubstr(
193-
"encountered unfixable aarch32 edge kind INVALID RELOCATION")));
194-
EXPECT_THAT_ERROR(
195-
applyFixupArm(*G, BThumb, InvalidEdge),
196-
FailedWithMessage(testing::HasSubstr(
197-
"encountered unfixable aarch32 edge kind INVALID RELOCATION")));
198-
EXPECT_THAT_ERROR(
199-
applyFixupThumb(*G, BThumb, InvalidEdge, ArmCfg),
200-
FailedWithMessage(testing::HasSubstr(
201-
"encountered unfixable aarch32 edge kind INVALID RELOCATION")));
202-
203178
for (Edge::Kind K = FirstThumbRelocation; K < LastThumbRelocation; K += 1) {
204179
Edge E(K, 0, TargetSymbol, 0);
205180
EXPECT_THAT_ERROR(applyFixupThumb(*G, BThumb, E, ArmCfg),

0 commit comments

Comments
 (0)