Skip to content

Commit 56936ec

Browse files
authored
Fixing FindUnusedPort method tcp_socket object creation with proper constructor parameter (#121879)
### Issue: Currently lldb `platform connect unix-connect://localhost:43045/` is failing and showing "Failed to connect port" error message. ![IMG_2492](https://github.com/user-attachments/assets/816931e2-8b06-427e-b11a-39b813094e36) ### Cause: TCPSocket(bool should_close, bool child_processes_inherit) constructor was removed in commit [c1dff71](c1dff71#diff-91817651b505a466ea94ddc44eca856f62073e03b05d0d0d2f4a55dcfea0002eL20). However, the tcp_socket object creation still passes the deleted constructor parameters, which causes the invocation of the wrong constructor. As a result, the `FindUnusedPort` method is unable to resolve the local port and always returns 0.
1 parent e7a83fc commit 56936ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static Status DeleteForwardPortWithAdb(uint16_t local_port,
6464

6565
static Status FindUnusedPort(uint16_t &port) {
6666
Status error;
67-
std::unique_ptr<TCPSocket> tcp_socket(new TCPSocket(true, false));
67+
std::unique_ptr<TCPSocket> tcp_socket(new TCPSocket(true));
6868
if (error.Fail())
6969
return error;
7070

0 commit comments

Comments
 (0)