Skip to content

Commit 5701a08

Browse files
committed
Address review feedback
- Delete blank line after "namespace {" - Extend glob test to cover multiple pattern matches; add NOT
1 parent e5529b0 commit 5701a08

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lld/ELF/MarkLive.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ using namespace lld;
4444
using namespace lld::elf;
4545

4646
namespace {
47-
4847
using SecOffset = std::pair<InputSectionBase *, unsigned>;
4948

5049
// Something that can have an independent reason for being live.

lld/test/ELF/why-live.test

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,9 @@ test_local:
153153

154154
## Globs match multiple cases. Multiple --why-live flags union.
155155

156-
# RUN: ld.lld a.o a.so --gc-sections --why-live=test_s* | FileCheck %s --check-prefix=MULTIPLE
157-
# RUN: ld.lld a.o a.so --gc-sections --why-live=test_simple --why-live=test_shared | FileCheck %s --check-prefix=MULTIPLE
156+
# RUN: ld.lld a.o a.so --gc-sections --why-live=test_se* --why-live=test_se* | FileCheck %s --check-prefix=MULTIPLE
157+
# RUN: ld.lld a.o a.so --gc-sections --why-live=test_section_offset --why-live=test_section_offset_within_symbol | FileCheck %s --check-prefix=MULTIPLE
158158

159-
# MULTIPLE-DAG: live symbol: a.o:(test_simple)
160-
# MULTIPLE-DAG: live symbol: a.so:(test_shared)
159+
# MULTIPLE-DAG: live symbol: a.o:(test_section_offset)
160+
# MULTIPLE-DAG: live symbol: a.o:(test_section_offset_within_symbol)
161+
# MULTIPLE-NOT: live symbol

0 commit comments

Comments
 (0)